Skip to content

fixed/simplified default ssl context #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acockburn merged 3 commits into from
Oct 22, 2025
Merged

fixed/simplified default ssl context #2449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5aca088
fixed/simplified default ssl context
jsl12 Oct 22, 2025
48cab9e
docs
jsl12 Oct 22, 2025
c2f34d1
Merge branch 'dev' into ha-ssl
acockburn Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions appdaemon/plugins/hass/hassplugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,8 @@ def create_session(self) -> aiohttp.ClientSession:
"""Handles creating an :py:class:`~aiohttp.ClientSession` with the cert information from the plugin config
and the authorization headers for the `REST API <https://developers.home-assistant.io/docs/api/rest>`_.
"""
if self.config.cert_path is not None:
ssl_context = ssl.create_default_context(capath=self.config.cert_path)
conn = aiohttp.TCPConnector(ssl_context=ssl_context, verify_ssl=self.config.cert_verify)
else:
conn = aiohttp.TCPConnector(ssl=False)
ssl_context = ssl.create_default_context(capath=self.config.cert_path)
conn = aiohttp.TCPConnector(ssl_context=ssl_context)

connect_timeout_secs = self.config.connect_timeout.total_seconds()
return aiohttp.ClientSession(
Expand Down
1 change: 1 addition & 0 deletions docs/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- Fix for sunrise and sunset with offsets - contributed by [ekutner](https://github.com/ekutner)
- Fix for random MQTT disconnects - contributed by [Xsandor](https://github.com/Xsandor)
- Fix for connecting to Home Assistant with https
- Fix for persistent namespaces in Python 3.12
- Better error handling for receiving huge websocket messages in the Hass plugin

Expand Down
Loading