chore: duplicate view with or without embeded (#441)

* chore: duplicate view with or without embeded

* chore: fmt

Author: appflowy

collab/src/database/database.rs

@@ -1483,16 +1483,25 @@ impl Database {
     self.body.fields.get_all_fields(&txn)
   }
 
+  /// Collect full database data for duplication/import/export.
+  /// If `include_embedded` is false, embedded views are excluded.
   pub async fn get_database_data(
     &self,
     chunk_size: usize,
     auto_fetch: bool,
+    include_embedded: bool,
   ) -> Result<DatabaseData, CollabError> {
     let txn = self.collab.transact();
 
     let database_id = self.body.get_database_id(&txn)?;
     let inline_view_id = self.body.get_inline_view_id(&txn);
-    let views = self.get_all_views(true);
+    let views = self
+      .body
+      .views
+      .get_all_views(&txn, include_embedded)
+      .into_iter()
+      .filter(|view| !view.is_inline)
+      .collect();
     let fields = self.body.get_fields_in_view(&txn, &inline_view_id, None);
     let rows_stream = self.get_all_rows(chunk_size, None, auto_fetch).await?;
     let rows: Vec<Row> = rows_stream
@@ -1523,7 +1532,7 @@ impl Database {
   }
 
   pub async fn to_json_value(&self) -> Result<JsonValue, CollabError> {
-    let database_data = self.get_database_data(20, false).await?;
+    let database_data = self.get_database_data(20, false, false).await?;
     Ok(serde_json::to_value(&database_data).unwrap())
   }
 

collab/src/database/database_remapper.rs

@@ -87,7 +87,7 @@ impl DatabaseCollabRemapper {
       body: database_body,
       collab_service,
     };
-    let database_data = database.get_database_data(20, false).await?;
+    let database_data = database.get_database_data(20, false, true).await?;
     Ok(database_data)
   }
 

collab/src/database/entity.rs

@@ -223,14 +223,14 @@ pub struct CreateDatabaseParams {
 }
 
 impl CreateDatabaseParams {
-  /// This function creates a converts a `CreateDatabaseParams` that can be used to create a new
-  /// database with the same data inside the given `DatabaseData` struct containing all the
-  /// data of a database. The internal `database_id`, the database views' `view_id`s and the rows'
-  /// `row_id`s will all be regenerated.
+  /// Convert a `DatabaseData` into `CreateDatabaseParams` for duplicating a database.
+  /// The internal `database_id`, database views' `view_id`s, and rows' `row_id`s are regenerated.
+  /// If `include_embedded` is false, embedded views are not duplicated.
   pub fn from_database_data(
     data: DatabaseData,
     database_view_id: DatabaseViewId,
     new_database_view_id: DatabaseViewId,
+    include_embedded: bool,
   ) -> Self {
     let database_id = gen_database_id();
     let timestamp = timestamp();
@@ -257,6 +257,7 @@ impl CreateDatabaseParams {
     let create_view_params = data
       .views
       .into_iter()
+      .filter(|view| include_embedded || !view.embedded)
       .map(|view| CreateViewParams {
         database_id,
         view_id: if view.id == database_view_id {

collab/tests/database/database_test/view_test.rs

@@ -5,7 +5,7 @@ use assert_json_diff::assert_json_eq;
 use collab::core::collab::{CollabOptions, default_client_id};
 use collab::core::origin::CollabOrigin;
 use collab::database::database::{DatabaseBody, DatabaseData, gen_row_id};
-use collab::database::entity::CreateViewParams;
+use collab::database::entity::{CreateDatabaseParams, CreateViewParams};
 use collab::database::fields::Field;
 use collab::database::rows::{CreateRowParams, Row};
 use collab::database::views::{DatabaseLayout, LayoutSetting, OrderObjectPosition};
@@ -249,11 +249,52 @@ async fn duplicate_database_view_test() {
   assert_eq!(view.database_id, duplicated_view.database_id);
 }
 
+#[tokio::test]
+async fn duplicate_database_excludes_embedded_views_test() {
+  let database_id = uuid::Uuid::new_v4();
+  let mut database_test = create_database_with_default_data(1, &database_id.to_string()).await;
+
+  let embedded_view_id = Uuid::new_v4();
+  database_test
+    .create_linked_view(CreateViewParams {
+      database_id,
+      view_id: embedded_view_id,
+      name: "embedded view".to_string(),
+      embedded: true,
+      ..Default::default()
+    })
+    .unwrap();
+
+  let data = database_test
+    .get_database_data(20, false, true)
+    .await
+    .unwrap();
+
+  let non_embedded_view_id = data.views.iter().find(|v| !v.embedded).unwrap().id;
+
+  let params_without_embedded = CreateDatabaseParams::from_database_data(
+    data.clone(),
+    non_embedded_view_id,
+    Uuid::new_v4(),
+    false,
+  );
+  assert_eq!(params_without_embedded.views.len(), 1);
+  assert!(params_without_embedded.views.iter().all(|v| !v.embedded));
+
+  let params_with_embedded =
+    CreateDatabaseParams::from_database_data(data, non_embedded_view_id, Uuid::new_v4(), true);
+  assert_eq!(params_with_embedded.views.len(), 2);
+  assert!(params_with_embedded.views.iter().any(|v| v.embedded));
+}
+
 #[tokio::test]
 async fn database_data_serde_test() {
   let database_id = uuid::Uuid::new_v4();
   let database_test = create_database_with_default_data(1, &database_id.to_string()).await;
-  let database_data = database_test.get_database_data(20, false).await.unwrap();
+  let database_data = database_test
+    .get_database_data(20, false, false)
+    .await
+    .unwrap();
 
   let json = database_data.to_json().unwrap();
   let database_data2 = DatabaseData::from_json(&json).unwrap();

collab/tests/importer/workspace/database_collab_remapper.rs

@@ -43,7 +43,7 @@ async fn test_parse_real_database_json() {
   let fields = database.get_all_fields();
   assert_eq!(fields.len(), 5);
 
-  let database_data = database.get_database_data(20, false).await.unwrap();
+  let database_data = database.get_database_data(20, false, true).await.unwrap();
   assert_eq!(database_data.rows.len(), 5);
 
   let original_uuids = [

collab/tests/importer/workspace/workspace_remapper_test.rs

@@ -115,7 +115,7 @@ async fn test_workspace_remapper_with_row_meta() {
   assert_eq!(databases.len(), 1);
 
   let database = &databases[0];
-  let database_data = database.get_database_data(20, false).await.unwrap();
+  let database_data = database.get_database_data(20, false, true).await.unwrap();
 
   assert_eq!(database_data.row_metas.len(), 4);
   assert_eq!(database_data.rows.len(), 4);