feat: add field settings, type options and layout settings #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
force-pushed
the
add-common-database-entities
branch
6 times, most recently
from
a1969fa to
bec8f5f
Compare
khorshuheng
force-pushed
the
add-common-database-entities
branch
from
bec8f5f to
e009a74
Compare
khorshuheng
changed the title
appflowy
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field settings, group settings, layout settings and some type options are currently defined on rust-lib in AppFlowy repository instead of AppFlowy Collab. There are recent features planned for AppFlowy Cloud, which requires the backend service to have access to the above structs and functions. As it is not possible for AppFlowy Cloud to import the crates in rust-lib, we will duplicatesthese settings on AppFlowy Collab instead.
After this, we will need to update the rust-lib crate, to use the settings from AppFlowy Collab instead of defining them in the crate.