Skip to content

feat: expose add and delete block #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khorshuheng merged 1 commit into from
Feb 20, 2025
Merged

feat: expose add and delete block #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions collab-document/src/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ impl DocumentBody {
Ok(buf)
}

fn insert_block(
pub fn insert_block(
&self,
txn: &mut TransactionMut,
block: Block,
Expand Down Expand Up @@ -709,7 +709,11 @@ impl DocumentBody {
/// 1. delete all the children of this block
/// 2. delete the block from its parent
/// 3. delete the block from the block map
fn delete_block(&self, txn: &mut TransactionMut, block_id: &str) -> Result<(), DocumentError> {
pub fn delete_block(
&self,
txn: &mut TransactionMut,
block_id: &str,
) -> Result<(), DocumentError> {
let block = match self.block_operation.get_block_with_txn(txn, block_id) {
Some(block) => block,
None => return Err(DocumentError::BlockIsNotFound),
Expand Down
Loading