-
Notifications
You must be signed in to change notification settings - Fork 116
feat: split jest test and e2e test #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR splits the CI testing: E2E (Cypress) tests are moved to a new File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lumixraku - I've reviewed your changes - here's some feedback:
- Please complete the PR description template to provide context for these changes.
- The removal of the MUI icon import plugin changes how icons are imported; ensure this new direct import pattern is consistently applied or documented.
- With E2E coverage moved to
e2e.yaml, consider renamingweb_coverage.yamlto more accurately reflect its now specific scope (e.g.,web_unit_coverage.yaml).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0f090a7 to
f228450
Compare
73dbca1 to
6073adf
Compare
85b268e to
11df05e
Compare
8c86e93 to
e59c460
Compare
Publish/Unpublish/visit Link Test
Publish/Unpublish/visit Link Test
Description
I noticed that the unit tests and E2E tests are currently in the same task. However, as the number of test cases is bound to increase in the future, the test execution time will become longer. I think Jest and E2E tests can be separated into two independent and parallel tasks.
Checklist
General
Testing
Feature-Specific
Summary by Sourcery
Split and improve test coverage configuration for AppFlowy Web project
Enhancements:
CI:
Tests:
Chores: