Skip to content

Console log #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appflowy merged 2 commits into from
Dec 2, 2025
Merged

Console log #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
199e9c8
chore: log json
appflowy Dec 2, 2025
92d6e31
chore: use log
appflowy Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions src/application/slate-yjs/command/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import {
YjsEditorKey,
} from '@/application/types';
import { EditorInlineAttributes } from '@/slate-editor';
import { Log } from '@/utils/log';
import { renderDate } from '@/utils/time';

export const CustomEditor = {
Expand Down Expand Up @@ -114,7 +115,7 @@ export const CustomEditor = {
const entry = findSlateEntryByBlockId(editor, blockId);

if (!entry) {
console.error('Block not found');
Log.error('Block not found');
return;
}

Expand Down Expand Up @@ -149,7 +150,7 @@ export const CustomEditor = {
},

deleteBlockBackward(editor: YjsEditor, at?: BaseRange) {
console.trace('deleteBlockBackward', editor.selection, at);
Log.trace('deleteBlockBackward', editor.selection, at);

const sharedRoot = getSharedRoot(editor);
const newAt = getSelectionOrThrow(editor, at);
Expand All @@ -162,7 +163,7 @@ export const CustomEditor = {
const blockEntry = getBlockEntry(editor, point);

if (!blockEntry) {
console.warn('Block not found', point);
Log.warn('Block not found', point);
return;
}

Expand Down Expand Up @@ -208,7 +209,7 @@ export const CustomEditor = {
const blockEntry = getBlockEntry(editor, point);

if (!blockEntry) {
console.warn('Block not found', point);
Log.warn('Block not found', point);
return;
}

Expand Down Expand Up @@ -327,15 +328,15 @@ export const CustomEditor = {
const endResult = blockResults.find((r) => r.isEnd);

if (!startResult?.newId || !endResult?.newId) {
console.warn('Failed to get new block IDs after tab operation');
Log.warn('Failed to get new block IDs after tab operation');
return;
}

const newStartBlockEntry = findSlateEntryByBlockId(editor, startResult.newId);
const newEndBlockEntry = findSlateEntryByBlockId(editor, endResult.newId);

if (!newStartBlockEntry || !newEndBlockEntry) {
console.warn('Failed to find new block entries after tab operation');
Log.warn('Failed to find new block entries after tab operation');
// Try to restore selection using original selection
const fallbackSelection = findNearestValidSelection(editor, originalSelection);

Expand Down Expand Up @@ -380,23 +381,23 @@ export const CustomEditor = {
};
}
} catch (error) {
console.warn('Error constructing new selection paths:', error);
Log.warn('Error constructing new selection paths:', error);
newSelection = null;
}

// Try to apply the new selection, with multiple fallback strategies
if (newSelection && isValidSelection(editor, newSelection)) {
console.debug('✅ Using calculated selection:', newSelection);
Log.debug('✅ Using calculated selection:', newSelection);
Transforms.select(editor, newSelection);
} else {
console.warn('⚠️ Calculated selection invalid, trying fallback strategies');
Log.warn('⚠️ Calculated selection invalid, trying fallback strategies');

// Strategy 1: Try to find nearest valid selection from our calculated selection
if (newSelection) {
const nearestFromCalculated = findNearestValidSelection(editor, newSelection);

if (nearestFromCalculated) {
console.debug('✅ Using nearest from calculated:', nearestFromCalculated);
Log.debug('✅ Using nearest from calculated:', nearestFromCalculated);
Transforms.select(editor, nearestFromCalculated);
return;
}
Expand All @@ -406,7 +407,7 @@ export const CustomEditor = {
const nearestFromOriginal = findNearestValidSelection(editor, originalSelection);

if (nearestFromOriginal) {
console.debug('✅ Using nearest from original:', nearestFromOriginal);
Log.debug('✅ Using nearest from original:', nearestFromOriginal);
Transforms.select(editor, nearestFromOriginal);
return;
}
Expand All @@ -417,23 +418,23 @@ export const CustomEditor = {
const startOfBlock = Editor.start(editor, newStartBlockPath);

if (isValidSelection(editor, { anchor: startOfBlock, focus: startOfBlock })) {
console.debug('✅ Using start of block:', startOfBlock);
Log.debug('✅ Using start of block:', startOfBlock);
Transforms.select(editor, startOfBlock);
return;
}
} catch (error) {
console.warn('Failed to select start of block:', error);
Log.warn('Failed to select start of block:', error);
}
}

// Strategy 4: Last resort - find any valid selection in the document
const documentSelection = findNearestValidSelection(editor, null);

if (documentSelection) {
console.debug('✅ Using document fallback:', documentSelection);
Log.debug('✅ Using document fallback:', documentSelection);
Transforms.select(editor, documentSelection);
} else {
console.warn('❌ Could not establish any valid selection after tab operation');
Log.warn('❌ Could not establish any valid selection after tab operation');
}
}
},
Expand All @@ -455,7 +456,7 @@ export const CustomEditor = {
const blockEntry = getBlockEntry(editor, point);

if (!blockEntry) {
console.warn('Block not found', point);
Log.warn('Block not found', point);
return;
}

Expand Down Expand Up @@ -615,7 +616,7 @@ export const CustomEditor = {
return Boolean((attributes as Record<string, boolean | string>)[key]);
});
} catch (error) {
console.warn('Error checking mark in expanded selection:', error);
Log.warn('Error checking mark in expanded selection:', error);
return false;
}
}
Expand All @@ -625,7 +626,7 @@ export const CustomEditor = {

return marks ? !!marks[key] : false;
} catch (error) {
console.warn('Error checking mark at collapsed selection:', error);
Log.warn('Error checking mark at collapsed selection:', error);
return false;
}
},
Expand All @@ -650,7 +651,7 @@ export const CustomEditor = {
return attributes as EditorInlineAttributes;
});
} catch (error) {
console.warn('Error getting all marks:', error);
Log.warn('Error getting all marks:', error);
return [];
}
}
Expand All @@ -660,7 +661,7 @@ export const CustomEditor = {

return [marks];
} catch (error) {
console.warn('Error getting marks at collapsed selection:', error);
Log.warn('Error getting marks at collapsed selection:', error);
return [];
}
},
Expand Down Expand Up @@ -697,7 +698,7 @@ export const CustomEditor = {
const parent = getBlock(blockId, sharedRoot);

if (!parent) {
console.warn('Parent block not found');
Log.warn('Parent block not found');
return;
}

Expand All @@ -712,7 +713,7 @@ export const CustomEditor = {
);

if (!newBlockId) {
console.warn('Failed to add block');
Log.warn('Failed to add block');
return;
}

Expand All @@ -731,7 +732,7 @@ export const CustomEditor = {
return newBlockId;
}
} catch (e) {
console.error(e);
Log.error(e);
}
},

Expand Down Expand Up @@ -778,7 +779,7 @@ export const CustomEditor = {
return newBlockId;
}
} catch (e) {
console.error(e);
Log.error(e);
}
},

Expand All @@ -795,7 +796,7 @@ export const CustomEditor = {
const parent = getParent(blockId, sharedRoot);

if (!parent) {
console.warn('Parent block not found');
Log.warn('Parent block not found');
return;
}

Expand Down Expand Up @@ -872,7 +873,7 @@ export const CustomEditor = {
const prevIndex = getBlockIndex(prevId || blockId, sharedRoot);

if (!parent) {
console.warn('Parent block not found');
Log.warn('Parent block not found');
return;
}

Expand All @@ -885,7 +886,7 @@ export const CustomEditor = {
newBlockId = deepCopyBlock(sharedRoot, block);

if (!newBlockId) {
console.warn('Copied block not found');
Log.warn('Copied block not found');
return;
}

Expand Down
3 changes: 0 additions & 3 deletions src/application/slate-yjs/plugins/withYjs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export function withYjs<T extends Editor>(
}
): T & YjsEditor {
const {
id,
uploadFile,
localOrigin = CollabOrigin.Local,
readSummary,
Expand Down Expand Up @@ -127,7 +126,6 @@ export function withYjs<T extends Editor>(
}

onContentChange?.(content.children);
console.debug('===initializeDocumentContent', e.children);
Editor.normalize(e, { force: true });
};

Expand Down Expand Up @@ -181,7 +179,6 @@ export function withYjs<T extends Editor>(
throw new Error('Already connected');
}

console.debug('===connect', id);
initializeDocumentContent();
e.sharedRoot.observeDeep(handleYEvents);
connectSet.add(e);
Expand Down
Loading
Loading