chore: filter out database view

[appflowy]

Description

---

Checklist

General

• I've included relevant documentation or comments for the changes introduced.
• I've tested the changes in multiple environments (e.g., different browsers, operating systems).

Testing

• I've added or updated tests to validate the changes introduced for AppFlowy Web.

Feature-Specific

• For feature additions, I've added a preview (video, screenshot, or demo) in the "Feature Preview" section.
• I've verified that this feature integrates seamlessly with existing functionality.

Summary by Sourcery

Ensure legacy databases are correctly surfaced in linking/mention UIs while hiding database child views, and add regression tests for these behaviors.

Bug Fixes:

• Include legacy top-level databases alongside database containers in the slash menu "Link to existing database" picker.
• Exclude database child views and embedded database views from mention panel results to avoid duplicate or irrelevant entries.
• Automatically expand database tree items while searching so filtered results are visible without manual expansion.

Tests:

• Add Cypress end-to-end coverage verifying legacy database visibility in the slash menu and absence of duplicate database child views in the mention panel.

[sourcery-ai]

Reviewer's Guide

Refines how databases and views are discovered and presented in the slash panel and mention panel, ensuring legacy top‑level databases remain selectable while child/embedded database views are filtered out, and adds Cypress coverage for these behaviors.

File-Level Changes

Change	Details	Files
Always expand database tree items while searching and avoid toggling expansion state during search interactions in the slash panel.	Extend DatabaseTreeItem props to accept an optional isSearching flag. Introduce effectiveExpanded state that forces nodes open while searching but keeps normal expansion behavior otherwise. Guard click and chevron toggle handlers so they do not change expanded state when isSearching is true. Propagate isSearching to child DatabaseTreeItem instances and base chevron rotation and child rendering on effectiveExpanded instead of expanded.	src/components/editor/components/panels/slash-panel/SlashPanel.tsx
Change database selection logic for the slash command picker to include legacy top-level databases but exclude child/embedded database views.	Replace flattenViews-based database discovery with a tree walk that tracks whether the current parent is a database. Treat database containers (is_database_container) as always selectable databases. Treat non-container database views as selectable only when they are top-level (no database parent) and not embedded (extra.embedded is falsy). Skip child views of databases and embedded database views from the selectable list while still recursing into their children as appropriate. Simplify debug logging to report only the count and names of selectable database views.	src/components/editor/components/panels/slash-panel/SlashPanel.tsx
Tighten mentionable view collection to skip spaces, database child views, and embedded database views so the mention panel does not show duplicated database views.	Replace flattenViews + filter in MentionPanel with a tree walk that builds a mentionable list. Skip views that are spaces, children of database views, or embedded views using isDatabaseLayout and isEmbeddedView helpers. Continue to de-duplicate by view_id via uniqBy before sorting by last_edited_time.	src/components/editor/components/panels/mention-panel/MentionPanel.tsx
Add Cypress end-to-end tests to lock in legacy database visibility in the slash menu and to prevent duplicate database child views in the mention panel.	Create a new Cypress spec exercising a legacy test workspace with legacy top-level databases and child database views. Verify that a legacy database named "Trip" appears in the slash menu database picker when using the Linked Grid command, even in mixed container/legacy workspaces. Verify that database child views like "View of Trip" do not appear in the mention panel search results while the parent database "Trip" does. Use shared auth, selector, and logging helpers to keep tests stable and readable.	cypress/e2e/embeded/database/legacy-database-slash-menu.cy.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The recursive traversal logic for filtering database/mentionable views in SlashPanel and MentionPanel is now quite similar; consider extracting a shared helper (e.g. in a views utility module) so the rules live in one place and stay consistent over time.
• The new Cypress spec duplicates the same login and workspace-navigation flow in both tests; consider factoring this into a shared beforeEach or helper function to keep the tests shorter and reduce maintenance overhead when the flow changes.
• The Cypress tests rely heavily on fixed cy.wait calls (e.g. 2000/8000 ms) for sync and loading; replacing these with explicit UI- or network-based waits (e.g. waiting for specific elements or API responses) would make the tests more robust and less flaky across environments.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The recursive traversal logic for filtering database/mentionable views in `SlashPanel` and `MentionPanel` is now quite similar; consider extracting a shared helper (e.g. in a views utility module) so the rules live in one place and stay consistent over time.
- The new Cypress spec duplicates the same login and workspace-navigation flow in both tests; consider factoring this into a shared `beforeEach` or helper function to keep the tests shorter and reduce maintenance overhead when the flow changes.
- The Cypress tests rely heavily on fixed `cy.wait` calls (e.g. 2000/8000 ms) for sync and loading; replacing these with explicit UI- or network-based waits (e.g. waiting for specific elements or API responses) would make the tests more robust and less flaky across environments.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}