Merged
Conversation
Reviewer's Guide by SourceryThis pull request modifies the Updated class diagram for HeadingNodeclassDiagram
class HeadingNode {
BlockType type
Object data
Element[] children
}
HeadingNode : +BlockType type
HeadingNode : +Object data
HeadingNode : +Element[] children
note for HeadingNode "HeadingNode now supports ToggleListBlock"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @qinluhe - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why
ToggleListBlockis being included in the outline.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| if (block.type === BlockType.HeadingBlock && (block as HeadingNode).data?.level <= maxDepth) { | ||
| function traverse(children: (Element | Text)[]) { | ||
| for(const block of children) { | ||
| if(Text.isText(block)) continue; |
There was a problem hiding this comment.
suggestion (code-quality): Use block braces for ifs, whiles, etc. (use-braces)
Suggested change
| if(Text.isText(block)) continue; | |
| if (Text.isText(block)) { |
Explanation
It is recommended to always use braces and create explicit statement blocks.Using the allowed syntax to just write a single statement can lead to very confusing
situations, especially where subsequently a developer might add another statement
while forgetting to add the braces (meaning that this wouldn't be included in the condition).
a2efbad to
f884ebd
Compare
appflowy
added a commit
that referenced
this pull request
Nov 14, 2025
…established. At this point, the (#72) WebSocket instance is fully initialized and ready for configuration
josue693
pushed a commit
to josue693/AppFlowy-Web
that referenced
this pull request
Dec 21, 2025
* chore: outlines support toggle h1-h6 * fix: add anchor point to outline content
josue693
pushed a commit
to josue693/AppFlowy-Web
that referenced
this pull request
Dec 21, 2025
…established. At this point, the (AppFlowy-IO#72) WebSocket instance is fully initialized and ready for configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
General
Testing
Feature-Specific
Summary by Sourcery
Enhancements: