Skip to content

Comments

chore: add shadcn popover#76

Merged
qinluhe merged 1 commit intochore/support-new-ui-designfrom
feat/popover
Apr 1, 2025
Merged

chore: add shadcn popover#76
qinluhe merged 1 commit intochore/support-new-ui-designfrom
feat/popover

Conversation

@richardshiue
Copy link
Contributor

@richardshiue richardshiue commented Apr 1, 2025

Description


Checklist

General

  • I've included relevant documentation or comments for the changes introduced.
  • I've tested the changes in multiple environments (e.g., different browsers, operating systems).

Testing

  • I've added or updated tests to validate the changes introduced for AppFlowy Web.

Feature-Specific

  • For feature additions, I've added a preview (video, screenshot, or demo) in the "Feature Preview" section.
  • I've verified that this feature integrates seamlessly with existing functionality.

Summary by Sourcery

Add Radix UI Popover component to the project's UI components

New Features:

  • Create a reusable Popover component with Radix UI Popover primitives

Chores:

  • Update pnpm-lock.yaml to include latest Radix UI Popover dependencies

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 1, 2025

Reviewer's Guide by Sourcery

This pull request adds the @radix-ui/react-popover component to the project. It installs the package, creates a Popover component with associated sub-components (PopoverTrigger, PopoverContent, PopoverAnchor), and applies styling and animations to the PopoverContent.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added the @radix-ui/react-popover component to the project.
  • Installed the @radix-ui/react-popover package.
  • Created a Popover component using the Radix UI popover primitives.
  • Created PopoverTrigger, PopoverContent, and PopoverAnchor sub-components.
  • Added styling and animation to the PopoverContent component.
pnpm-lock.yaml
package.json
src/components/ui/popover.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richardshiue - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief description of what this component does and how it should be used in the project.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richardshiue richardshiue marked this pull request as draft April 1, 2025 10:42
@qinluhe qinluhe marked this pull request as ready for review April 1, 2025 10:44
@qinluhe qinluhe merged commit af9c62e into chore/support-new-ui-design Apr 1, 2025
1 check passed
@qinluhe qinluhe deleted the feat/popover branch April 1, 2025 10:44
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It looks like we've already reviewed the commit d466ef5 in this pull request.

qinluhe added a commit that referenced this pull request Apr 2, 2025
* chore: import new ui system

* chore: modified padding and rounded

* chore: remove vertical padding

* chore: add shadow

* chore: add shadcn popover (#76)

* chore: add circle progress (#77)

* chore: add input (#78)

* feat: add shadcn toast (#80)

* chore: initial import

* chore: style

* chore: important

* chore: add dropdown menu (#81)

* feat: add shadcn tooltip (#79)

* chore: initial import

* chore: style

* chore: fix text size

* chore: add tooltip shortcut

* chore: code cleanup and add flex col

* chore: add avatar (#82)

* chore: add dialog (#83)

---------

Co-authored-by: Richard Shiue <71320345+richardshiue@users.noreply.github.com>
appflowy pushed a commit that referenced this pull request Nov 14, 2025
josue693 pushed a commit to josue693/AppFlowy-Web that referenced this pull request Dec 21, 2025
* chore: import new ui system

* chore: modified padding and rounded

* chore: remove vertical padding

* chore: add shadow

* chore: add shadcn popover (AppFlowy-IO#76)

* chore: add circle progress (AppFlowy-IO#77)

* chore: add input (AppFlowy-IO#78)

* feat: add shadcn toast (AppFlowy-IO#80)

* chore: initial import

* chore: style

* chore: important

* chore: add dropdown menu (AppFlowy-IO#81)

* feat: add shadcn tooltip (AppFlowy-IO#79)

* chore: initial import

* chore: style

* chore: fix text size

* chore: add tooltip shortcut

* chore: code cleanup and add flex col

* chore: add avatar (AppFlowy-IO#82)

* chore: add dialog (AppFlowy-IO#83)

---------

Co-authored-by: Richard Shiue <71320345+richardshiue@users.noreply.github.com>
josue693 pushed a commit to josue693/AppFlowy-Web that referenced this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants