Skip to content

Comments

chore: add circle progress#77

Merged
qinluhe merged 1 commit intochore/support-new-ui-designfrom
chore/support-spinner
Apr 1, 2025
Merged

chore: add circle progress#77
qinluhe merged 1 commit intochore/support-new-ui-designfrom
chore/support-spinner

Conversation

@qinluhe
Copy link
Contributor

@qinluhe qinluhe commented Apr 1, 2025

Description


Checklist

General

  • I've included relevant documentation or comments for the changes introduced.
  • I've tested the changes in multiple environments (e.g., different browsers, operating systems).

Testing

  • I've added or updated tests to validate the changes introduced for AppFlowy Web.

Feature-Specific

  • For feature additions, I've added a preview (video, screenshot, or demo) in the "Feature Preview" section.
  • I've verified that this feature integrates seamlessly with existing functionality.

Summary by Sourcery

Add a customizable circle progress component to the UI library

New Features:

  • Implement a flexible Progress component with support for different sizes, variants, and indeterminate states

Enhancements:

  • Update global CSS to include progress animation
  • Modify button component styling to use font-medium instead of font-semibold

Chores:

  • Add new SVG-based circular progress indicator component

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 1, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new Progress component, which renders a circular progress indicator with customizable styles and an indeterminate state animation. It also updates the Button component to use a medium font weight. The Progress component is implemented using SVG and styled with cva for easy customization.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new Progress component for displaying circular progress indicators.
  • Created a Progress component with customizable size, variant, and value.
  • Implemented indeterminate state with animated rotation.
  • Added styling using cva for different variants and sizes.
  • Included base and progress circles with configurable stroke width and line cap.
  • Calculated stroke offsets to reflect progress value.
  • Added storybook stories for the component.
src/components/ui/progress.tsx
Added a global CSS animation for the indeterminate progress state.
  • Defined a progress-container keyframe animation for rotation.
  • Applied the animation to the progress container when in indeterminate state.
src/styles/global.css
Updated the Button component to use a medium font weight.
  • Changed the font weight of the Button component from font-semibold to font-medium.
src/components/ui/button.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @qinluhe - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a utility function or a design token for the hardcoded dimensions and viewBox values in Progress.tsx.
  • The animation name progress-container is very generic; consider a more specific name.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@qinluhe qinluhe merged commit cef01c0 into chore/support-new-ui-design Apr 1, 2025
1 check passed
@qinluhe qinluhe deleted the chore/support-spinner branch April 1, 2025 10:45
qinluhe added a commit that referenced this pull request Apr 2, 2025
* chore: import new ui system

* chore: modified padding and rounded

* chore: remove vertical padding

* chore: add shadow

* chore: add shadcn popover (#76)

* chore: add circle progress (#77)

* chore: add input (#78)

* feat: add shadcn toast (#80)

* chore: initial import

* chore: style

* chore: important

* chore: add dropdown menu (#81)

* feat: add shadcn tooltip (#79)

* chore: initial import

* chore: style

* chore: fix text size

* chore: add tooltip shortcut

* chore: code cleanup and add flex col

* chore: add avatar (#82)

* chore: add dialog (#83)

---------

Co-authored-by: Richard Shiue <71320345+richardshiue@users.noreply.github.com>
appflowy added a commit that referenced this pull request Nov 14, 2025
josue693 pushed a commit to josue693/AppFlowy-Web that referenced this pull request Dec 21, 2025
* chore: import new ui system

* chore: modified padding and rounded

* chore: remove vertical padding

* chore: add shadow

* chore: add shadcn popover (AppFlowy-IO#76)

* chore: add circle progress (AppFlowy-IO#77)

* chore: add input (AppFlowy-IO#78)

* feat: add shadcn toast (AppFlowy-IO#80)

* chore: initial import

* chore: style

* chore: important

* chore: add dropdown menu (AppFlowy-IO#81)

* feat: add shadcn tooltip (AppFlowy-IO#79)

* chore: initial import

* chore: style

* chore: fix text size

* chore: add tooltip shortcut

* chore: code cleanup and add flex col

* chore: add avatar (AppFlowy-IO#82)

* chore: add dialog (AppFlowy-IO#83)

---------

Co-authored-by: Richard Shiue <71320345+richardshiue@users.noreply.github.com>
josue693 pushed a commit to josue693/AppFlowy-Web that referenced this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant