fix: some launch review issues

Author: asjqkkkk

frontend/appflowy_flutter/lib/mobile/presentation/inline_actions/mobile_inline_actions_menu_group.dart

@@ -122,12 +122,14 @@ class MobileInlineActionsWidget extends StatelessWidget {
                   item.icon!.call(isSelected),
                   SizedBox(width: 12),
                 ],
-                FlowyText.regular(
-                  item.label,
-                  figmaLineHeight: 18,
-                  overflow: TextOverflow.ellipsis,
-                  fontSize: 16,
-                  color: style.menuItemSelectedTextColor,
+                Flexible(
+                  child: FlowyText.regular(
+                    item.label,
+                    figmaLineHeight: 18,
+                    overflow: TextOverflow.ellipsis,
+                    fontSize: 16,
+                    color: style.menuItemSelectedTextColor,
+                  ),
                 ),
               ],
             ),

frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_widget.dart

@@ -5,6 +5,7 @@ import 'package:flutter/material.dart';
 
 import 'mobile_selection_menu_item.dart';
 import 'mobile_selection_menu_item_widget.dart';
+import 'slash_keyboard_service_interceptor.dart';
 
 class MobileSelectionMenuWidget extends StatefulWidget {
   const MobileSelectionMenuWidget({
@@ -61,6 +62,8 @@ class _MobileSelectionMenuWidgetState extends State<MobileSelectionMenuWidget> {
 
   int selectedIndex = 0;
 
+  late AppFlowyKeyboardServiceInterceptor keyboardInterceptor;
+
   List<SelectionMenuItem> get filterItems {
     final List<SelectionMenuItem> items = [];
     for (final item in widget.items) {
@@ -117,33 +120,51 @@ class _MobileSelectionMenuWidgetState extends State<MobileSelectionMenuWidget> {
   @override
   void initState() {
     super.initState();
-
-    final List<SelectionMenuItem> items = [];
-    for (final item in widget.items) {
-      if (item is MobileSelectionMenuItem) {
-        item.onSelected = () {
-          if (mounted) {
-            setState(() {
-              _showingItems = item.children
-                  .map((e) => e..onSelected = widget.onExit)
-                  .toList();
-            });
-          }
-        };
-      }
-      items.add(item);
-    }
-    _showingItems = items;
+    _showingItems = buildInitialItems();
 
     keepEditorFocusNotifier.increase();
     WidgetsBinding.instance.addPostFrameCallback((_) {
       _focusNode.requestFocus();
     });
+
+    keyboardInterceptor = SlashKeyboardServiceInterceptor(
+      onDelete: () async {
+        if (!mounted) return false;
+        final hasItemsChanged = !isInitialItems();
+        if (keyword.isEmpty && hasItemsChanged) {
+          setState(() {
+            _showingItems = buildInitialItems();
+            selectedIndex = 0;
+          });
+          return true;
+        }
+        return false;
+      },
+      onEnter: () {
+        if (!mounted) return;
+        if (_showingItems.isEmpty) return;
+        final item = _showingItems[selectedIndex];
+        if (item is MobileSelectionMenuItem) {
+          selectedIndex = 0;
+          item.onSelected?.call();
+        } else {
+          item.handler(
+            editorState,
+            menuService,
+            context,
+          );
+        }
+      },
+    );
+    editorState.service.keyboardService
+        ?.registerInterceptor(keyboardInterceptor);
     editorState.selectionNotifier.addListener(onSelectionChanged);
   }
 
   @override
   void dispose() {
+    editorState.service.keyboardService
+        ?.unregisterInterceptor(keyboardInterceptor);
     editorState.selectionNotifier.removeListener(onSelectionChanged);
     _focusNode.dispose();
     keepEditorFocusNotifier.decrease();
@@ -295,4 +316,34 @@ class _MobileSelectionMenuWidgetState extends State<MobileSelectionMenuWidget> {
       ),
     );
   }
+
+  List<SelectionMenuItem> buildInitialItems() {
+    final List<SelectionMenuItem> items = [];
+    for (final item in widget.items) {
+      if (item is MobileSelectionMenuItem) {
+        item.onSelected = () {
+          if (mounted) {
+            setState(() {
+              _showingItems = item.children
+                  .map((e) => e..onSelected = widget.onExit)
+                  .toList();
+            });
+          }
+        };
+      }
+      items.add(item);
+    }
+    return items;
+  }
+
+  bool isInitialItems() {
+    if (_showingItems.length != widget.items.length) return false;
+    int i = 0;
+    for (final item in _showingItems) {
+      final widgetItem = widget.items[i];
+      if (widgetItem.name != item.name) return false;
+      i++;
+    }
+    return true;
+  }
 }

frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/slash_keyboard_service_interceptor.dart

@@ -0,0 +1,42 @@
+import 'package:appflowy/plugins/document/presentation/editor_plugins/keyboard_interceptor/keyboard_interceptor.dart';
+import 'package:appflowy_editor/appflowy_editor.dart';
+import 'package:flutter/foundation.dart';
+import 'package:flutter/services.dart';
+
+class SlashKeyboardServiceInterceptor extends EditorKeyboardInterceptor {
+  SlashKeyboardServiceInterceptor({
+    required this.onDelete,
+    required this.onEnter,
+  });
+
+  final AsyncValueGetter<bool> onDelete;
+  final VoidCallback onEnter;
+
+  @override
+  Future<bool> interceptDelete(
+    TextEditingDeltaDeletion deletion,
+    EditorState editorState,
+  ) async {
+    final intercept = await onDelete.call();
+    if (intercept) {
+      return true;
+    } else {
+      return super.interceptDelete(deletion, editorState);
+    }
+  }
+
+  @override
+  Future<bool> interceptInsert(
+    TextEditingDeltaInsertion insertion,
+    EditorState editorState,
+    List<CharacterShortcutEvent> characterShortcutEvents,
+  ) async {
+    final text = insertion.textInserted;
+    if (text.contains('\n')) {
+      onEnter.call();
+      return true;
+    }
+    return super
+        .interceptInsert(insertion, editorState, characterShortcutEvents);
+  }
+}

frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items/mobile_items.dart

@@ -11,20 +11,22 @@ final List<SelectionMenuItem> mobileItems = [
   textStyleMobileSlashMenuItem,
   listMobileSlashMenuItem,
   toggleListMobileSlashMenuItem,
-  fileOrMediaMobileSlashMenuItem,
-  decorationsMobileSlashMenuItem,
+  fileAndMediaMobileSlashMenuItem,
   tableSlashMenuItem,
+  visualsMobileSlashMenuItem,
   dateOrReminderSlashMenuItem,
+  subPageSlashMenuItem,
   advancedMobileSlashMenuItem,
 ];
 
 final List<SelectionMenuItem> mobileItemsInTale = [
   textStyleMobileSlashMenuItem,
   listMobileSlashMenuItem,
   toggleListMobileSlashMenuItem,
-  fileOrMediaMobileSlashMenuItem,
-  decorationsMobileSlashMenuItem,
+  fileAndMediaMobileSlashMenuItem,
+  visualsMobileSlashMenuItem,
   dateOrReminderSlashMenuItem,
+  subPageSlashMenuItem,
   advancedMobileSlashMenuItem,
 ];
 
@@ -64,7 +66,7 @@ MobileSelectionMenuItem listMobileSlashMenuItem = MobileSelectionMenuItem(
 );
 
 MobileSelectionMenuItem toggleListMobileSlashMenuItem = MobileSelectionMenuItem(
-  getName: LocaleKeys.document_slashMenu_name_toggleList.tr,
+  getName: LocaleKeys.document_slashMenu_name_toggle.tr,
   handler: _handler,
   icon: (_, isSelected, style) => SelectableSvgWidget(
     data: FlowySvgs.slash_menu_icon_toggle_s,
@@ -80,9 +82,9 @@ MobileSelectionMenuItem toggleListMobileSlashMenuItem = MobileSelectionMenuItem(
   ],
 );
 
-MobileSelectionMenuItem fileOrMediaMobileSlashMenuItem =
+MobileSelectionMenuItem fileAndMediaMobileSlashMenuItem =
     MobileSelectionMenuItem(
-  getName: LocaleKeys.document_slashMenu_name_fileOrMedia.tr,
+  getName: LocaleKeys.document_slashMenu_name_fileAndMedia.tr,
   handler: _handler,
   icon: (_, isSelected, style) => SelectableSvgWidget(
     data: FlowySvgs.slash_menu_icon_file_s,
@@ -97,9 +99,8 @@ MobileSelectionMenuItem fileOrMediaMobileSlashMenuItem =
   ],
 );
 
-MobileSelectionMenuItem decorationsMobileSlashMenuItem =
-    MobileSelectionMenuItem(
-  getName: LocaleKeys.document_slashMenu_name_decorations.tr,
+MobileSelectionMenuItem visualsMobileSlashMenuItem = MobileSelectionMenuItem(
+  getName: LocaleKeys.document_slashMenu_name_visuals.tr,
   handler: _handler,
   icon: (_, isSelected, style) => SelectableSvgWidget(
     data: FlowySvgs.slash_menu_icon_simple_table_s,
@@ -108,8 +109,9 @@ MobileSelectionMenuItem decorationsMobileSlashMenuItem =
   ),
   nameBuilder: slashMenuItemNameBuilder,
   children: [
-    quoteSlashMenuItem,
+    calloutSlashMenuItem,
     dividerSlashMenuItem,
+    quoteSlashMenuItem,
   ],
 );
 
@@ -123,8 +125,6 @@ MobileSelectionMenuItem advancedMobileSlashMenuItem = MobileSelectionMenuItem(
   ),
   nameBuilder: slashMenuItemNameBuilder,
   children: [
-    subPageSlashMenuItem,
-    calloutSlashMenuItem,
     codeBlockSlashMenuItem,
     mathEquationSlashMenuItem,
   ],

frontend/appflowy_flutter/lib/plugins/inline_actions/widgets/inline_actions_menu_group.dart

@@ -107,10 +107,12 @@ class _InlineActionsWidgetState extends State<InlineActionsWidget> {
                 icon.call(widget.isSelected),
                 SizedBox(width: 12),
               ],
-              FlowyText.regular(
-                widget.item.label,
-                figmaLineHeight: 18,
-                overflow: TextOverflow.ellipsis,
+              Flexible(
+                child: FlowyText.regular(
+                  widget.item.label,
+                  figmaLineHeight: 18,
+                  overflow: TextOverflow.ellipsis,
+                ),
               ),
             ],
           ),

frontend/resources/translations/en.json

@@ -1689,8 +1689,11 @@
       "name": {
         "textStyle": "Text Style",
         "list": "List",
-        "fileOrMedia": "File or Media",
-        "decorations": "Decorations",
+        "toggle": "Toggle",
+        "fileAndMedia": "File & Media",
+        "simpleTable": "Simple Table",
+        "visuals": "Visuals",
+        "document": "Document",
         "advanced": "Advanced",
         "text": "Text",
         "heading1": "Heading 1",