Skip to content

chore: improve the error UI of link preview #7741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asjqkkkk wants to merge 3 commits into from
Closed

chore: improve the error UI of link preview #7741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc0882c
chore: improve the error UI of link preview
asjqkkkk Apr 14, 2025
a23f8c9
Merge branch 'main' into fix/link_preview
asjqkkkk Apr 14, 2025
be061ee
Merge branch 'main' into fix/link_preview
asjqkkkk Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions ...b/plugins/document/presentation/editor_plugins/link_embed/link_embed_block_component.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,17 +185,26 @@ class LinkEmbedBlockComponentState

Widget buildContent(BuildContext context) {
final theme = AppFlowyTheme.of(context), textScheme = theme.textColorScheme;
final imageUrl = linkInfo.imageUrl ?? '';
return Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
Expanded(
child: ClipRRect(
borderRadius: const BorderRadius.vertical(top: Radius.circular(16)),
child: FlowyNetworkImage(
url: linkInfo.imageUrl ?? '',
width: MediaQuery.of(context).size.width,
),
),
child: imageUrl.isNotEmpty
? ClipRRect(
borderRadius:
const BorderRadius.vertical(top: Radius.circular(16)),
child: FlowyNetworkImage(
url: imageUrl,
width: MediaQuery.of(context).size.width,
),
)
: Center(
child: FlowySvg(
FlowySvgs.toolbar_link_earth_m,
size: Size.square(64),
),
),
),
MouseRegion(
cursor: SystemMouseCursors.click,
Expand Down
64 changes: 27 additions & 37 deletions ...er/lib/plugins/document/presentation/editor_plugins/link_preview/custom_link_preview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import 'package:universal_platform/universal_platform.dart';
import 'package:appflowy_ui/appflowy_ui.dart';

import 'custom_link_parser.dart';
import 'link_parsers/default_parser.dart';

class CustomLinkPreviewWidget extends StatelessWidget {
const CustomLinkPreviewWidget({
Expand Down Expand Up @@ -55,6 +56,7 @@ class CustomLinkPreviewWidget extends StatelessWidget {
final (fontSize, width) = UniversalPlatform.isDesktopOrWeb
? (documentFontSize, 160.0)
: (documentFontSize - 2, 120.0);
final displayTitle = title ?? Uri.tryParse(LinkInfoParser.formatUrl(url))?.host;
final Widget child = Container(
clipBehavior: Clip.hardEdge,
decoration: BoxDecoration(
Expand All @@ -74,34 +76,35 @@ class CustomLinkPreviewWidget extends StatelessWidget {
Expanded(
child: Padding(
padding: const EdgeInsets.fromLTRB(20, 12, 58, 12),
child: status != LinkLoadingStatus.idle
? buildLoadingOrErrorWidget()
child: status == LinkLoadingStatus.loading
? buildLoadingWidget()
: Column(
crossAxisAlignment: CrossAxisAlignment.start,
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: [
if (title != null)
if (displayTitle != null)
Padding(
padding: const EdgeInsets.only(bottom: 4.0),
child: FlowyText.medium(
title!,
displayTitle,
overflow: TextOverflow.ellipsis,
fontSize: fontSize,
color: textScheme.primary,
figmaLineHeight: 20,
),
),
if (description != null)
Padding(
padding: const EdgeInsets.only(bottom: 16.0),
child: FlowyText(
description!,
overflow: TextOverflow.ellipsis,
fontSize: fontSize - 4,
figmaLineHeight: 16,
color: textScheme.primary,
),
),
description == null
? Spacer()
: Padding(
padding: const EdgeInsets.only(bottom: 16.0),
child: FlowyText(
description!,
overflow: TextOverflow.ellipsis,
fontSize: fontSize - 4,
figmaLineHeight: 16,
color: textScheme.primary,
),
),
FlowyText(
url.toString(),
overflow: TextOverflow.ellipsis,
Expand Down Expand Up @@ -161,6 +164,7 @@ class CustomLinkPreviewWidget extends StatelessWidget {
}

Widget buildImage(BuildContext context) {
if (imageUrl == null) return const SizedBox.shrink();
final theme = AppFlowyTheme.of(context),
fillScheme = theme.fillColorScheme,
iconScheme = theme.iconColorTheme;
Expand Down Expand Up @@ -193,27 +197,13 @@ class CustomLinkPreviewWidget extends StatelessWidget {
);
}

Widget buildLoadingOrErrorWidget() {
if (status == LinkLoadingStatus.loading) {
return const Center(
child: SizedBox(
height: 16,
width: 16,
child: CircularProgressIndicator.adaptive(),
),
);
} else if (status == LinkLoadingStatus.error) {
return const Center(
child: SizedBox(
height: 16,
width: 16,
child: Icon(
Icons.error_outline,
color: Colors.red,
),
),
);
}
return SizedBox.shrink();
Widget buildLoadingWidget() {
return const Center(
child: SizedBox(
height: 16,
width: 16,
child: CircularProgressIndicator.adaptive(),
),
);
}
}
Loading