feat: improve password error message#7842
Merged
LucasXu0 merged 4 commits intoAppFlowy-IO:mainfrom Apr 28, 2025
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request improves the handling and display of password-related error messages in the settings screens by introducing a dedicated utility class. It parses backend error strings using regular expressions and displays specific, localized messages directly on the relevant input fields. Additionally, it updates the client-api dependency. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Missing translation | 29 | warning | contribute (via Fink 🐦) |
Contributor
There was a problem hiding this comment.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider refactoring the repeated error pattern matching logic within the UI components to reduce duplication.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Refactor password error handling to provide more specific feedback and update backend client dependencies.
Enhancements:
Build:
client-api,client-api-entity, andworkspace-templatedependencies to a newer revision.Chores: