Skip to content

Comments

fix: some mobile search UI issues#7845

Merged
LucasXu0 merged 11 commits intoAppFlowy-IO:mainfrom
asjqkkkk:fix/mobile/lr
Apr 29, 2025
Merged

fix: some mobile search UI issues#7845
LucasXu0 merged 11 commits intoAppFlowy-IO:mainfrom
asjqkkkk:fix/mobile/lr

Conversation

@asjqkkkk
Copy link
Collaborator

@asjqkkkk asjqkkkk commented Apr 28, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Refine the user interface for mobile search results and the selection menu.

Bug Fixes:

  • Display a default name for search results when the original name is empty.
  • Correct the alignment and increase the tappable area of the search cancel button.
  • Ensure the "No results" text in the selection menu uses the correct theme color instead of a hardcoded value.
  • Center the icon within its allocated space in the search result cell.
  • Add vertical spacing before the summary text in search result cells for better readability.
  • Adjust the height of the mobile search text field.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 28, 2025

Reviewer's Guide by Sourcery

This pull request addresses several UI issues in the mobile search and selection menu components, including layout adjustments, text handling, and theme integration.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Improved the layout and text handling within the mobile search result cells.
  • Used translated default page name when the item display name is empty.
  • Ensured the icon is properly sized and centered.
  • Added vertical spacing between the path and the content summary.
frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_cell.dart
Adjusted the mobile search text field height and refined the cancel button's layout and hit area.
  • Increased the overall height of the text field container.
  • Made the cancel button's tap area opaque.
  • Aligned the cancel button text to the left.
frontend/appflowy_flutter/lib/mobile/presentation/search/mobile_search_textfield.dart
Updated the 'No Results' text color in the mobile selection menu to use the theme's primary text color.
  • Switched from a hardcoded color to the theme's primary text color for the 'No Results' message.
frontend/appflowy_flutter/lib/mobile/presentation/selection_menu/mobile_selection_menu_widget.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @asjqkkkk - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider replacing magic numbers for dimensions and spacing with constants derived from the theme for better maintainability.
  • Good job replacing the hardcoded color with a theme value; check if other similar instances exist elsewhere in the mobile UI.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

) async {
final List<ReminderPB> availableReminders = [];
final reminderIds = reminders.map((e) => e.id).toSet();
final removedIds = <String>{};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we delete the removedIds, how do we perform the unreferenced reminder now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting removeIds here is not a correct way, however, I haven't thought of the most appropriate way to handle it

we'll ignore the unreferenced reminder now

@LucasXu0 LucasXu0 merged commit d28987d into AppFlowy-IO:main Apr 29, 2025
20 checks passed
@asjqkkkk asjqkkkk deleted the fix/mobile/lr branch April 29, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants