fix: some mobile search UI issues#7845
Merged
LucasXu0 merged 11 commits intoAppFlowy-IO:mainfrom Apr 29, 2025
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request addresses several UI issues in the mobile search and selection menu components, including layout adjustments, text handling, and theme integration. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @asjqkkkk - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider replacing magic numbers for dimensions and spacing with constants derived from the theme for better maintainability.
- Good job replacing the hardcoded color with a theme value; check if other similar instances exist elsewhere in the mobile UI.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LucasXu0
reviewed
Apr 29, 2025
| ) async { | ||
| final List<ReminderPB> availableReminders = []; | ||
| final reminderIds = reminders.map((e) => e.id).toSet(); | ||
| final removedIds = <String>{}; |
Collaborator
There was a problem hiding this comment.
If we delete the removedIds, how do we perform the unreferenced reminder now?
Collaborator
Author
There was a problem hiding this comment.
putting removeIds here is not a correct way, however, I haven't thought of the most appropriate way to handle it
we'll ignore the unreferenced reminder now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Refine the user interface for mobile search results and the selection menu.
Bug Fixes: