Skip to content

Comments

fix: unable to expand sidebar on Windows#7847

Merged
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
LucasXu0:fix_windows_issues
Apr 28, 2025
Merged

fix: unable to expand sidebar on Windows#7847
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
LucasXu0:fix_windows_issues

Conversation

@LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Apr 28, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Bug Fixes:

  • Ensure the sidebar toggles between expanded and hidden states when clicked, instead of always hiding.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 28, 2025

Reviewer's Guide by Sourcery

This pull request fixes an issue where the sidebar could not be expanded on Windows. The fix involves modifying the onPointerDown handler for the sidebar control area to toggle the sidebar's visibility (expand/collapse) based on its current state, rather than always hiding it.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modify sidebar collapse/expand logic
  • Check current sidebar expansion status
  • Toggle sidebar status based on current state
frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LucasXu0 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief explanation in the description on how this platform-agnostic code change addresses the Windows-specific issue mentioned in the title.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LucasXu0 LucasXu0 merged commit fb33e4d into AppFlowy-IO:main Apr 28, 2025
18 of 20 checks passed
LucasXu0 added a commit that referenced this pull request Jun 3, 2025
* fix: unable to collapse sidebar

* fix: unable to expand workspace menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant