Skip to content

Comments

fix: some lr issues#7848

Merged
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
asjqkkkk:fix/desktop/lr
Apr 28, 2025
Merged

fix: some lr issues#7848
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
asjqkkkk:fix/desktop/lr

Conversation

@asjqkkkk
Copy link
Collaborator

@asjqkkkk asjqkkkk commented Apr 28, 2025

  • On Windows, click to open an inline link doesn’t work for appflowy.com (no https://) as the link
  • On Windows, the link menu doesn’t close automatically after I click Apply
  • The sidebar collapse/uncollapse is broken. The shortcut is not working either. The shortcut displayed in the tooltip on hover is also not the right one.

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Fix link handling on Windows and restore sidebar toggle functionality.

Bug Fixes:

  • Allow opening links without an explicit protocol (e.g., "appflowy.com") on Windows.
  • Close the link editing popover automatically after clicking 'Apply'.
  • Restore the expand/collapse functionality of the sidebar toggle button.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 28, 2025

Reviewer's Guide by Sourcery

This pull request implements fixes for several UI issues. It modifies the URL launching logic to correctly handle links without a protocol on Windows, ensures the link editing menu automatically closes after applying changes, and refactors the sidebar toggle button implementation to address collapse/uncollapse functionality and shortcut issues.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Improved URL launching logic for Windows.
  • Added Windows to the platforms that check for and add the 'https://' scheme to URLs if missing.
frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart
Ensure link editing menu closes after applying changes.
  • Called the dismiss method after the apply callback.
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_edit_menu.dart
Refactored sidebar toggle button logic and layout on Windows.
  • Simplified the Windows title bar layout by removing an unnecessary Column wrapper.
  • Replaced the Listener with a GestureDetector for handling taps on the toggle button.
  • Explicitly handled the toggle logic between hidden and expanded menu states in the onTap callback.
  • Changed hit test behavior to opaque.
  • Added a red dot indicator to the button area.
frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @asjqkkkk - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider updating the PR title to be more descriptive of the specific issues being fixed (e.g., sidebar toggle, link handling).
  • The addition of NumberedRedDot doesn't seem directly related to the issues listed in the description; could this be part of a separate change?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

],
);

return FlowyTooltip(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucasXu0 LucasXu0 merged commit 9353863 into AppFlowy-IO:main Apr 28, 2025
5 checks passed
@asjqkkkk asjqkkkk deleted the fix/desktop/lr branch April 28, 2025 14:20
LucasXu0 added a commit that referenced this pull request Jun 3, 2025
Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants