Skip to content

Comments

chore: support aarch64 windows#7853

Closed
LucasXu0 wants to merge 3 commits intoAppFlowy-IO:mainfrom
LucasXu0:arm64_windows
Closed

chore: support aarch64 windows#7853
LucasXu0 wants to merge 3 commits intoAppFlowy-IO:mainfrom
LucasXu0:arm64_windows

Conversation

@LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Apr 29, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Add build and CI support for Windows ARM64 (aarch64-pc-windows-msvc).

Build:

  • Define development and production build configurations for Windows ARM64.
  • Install the aarch64-pc-windows-msvc Rust target during setup.
  • Rename existing Windows x86_64 build configurations for clarity.
  • Install the aarch64-unknown-linux-gnu Rust target during setup.

CI:

  • Introduce a new CI job to build for Windows ARM64.
  • Rename the existing Windows x86_64 CI job for clarity.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 29, 2025

Reviewer's Guide by Sourcery

This pull request adds support for building AppFlowy for the AArch64 architecture on Windows. It involves updating the CI workflow to include a new job for Windows ARM64 builds, modifying the Makefile configurations to define build environments for Windows AArch64, and adding the AArch64 rust targets to the environment setup scripts.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add CI job to build for Windows AArch64.
  • Renamed the existing Windows x86_64 build job.
  • Added a new CI job specifically for building on Windows ARM64 (aarch64) architecture.
.github/workflows/flutter_ci.yaml
Update Makefile configurations to support Windows AArch64 builds.
  • Renamed the existing Windows x86_64 build environment.
  • Added new build environments for development and production on Windows ARM64 (aarch64).
frontend/Makefile.toml
Add AArch64 rust targets to environment setup scripts.
  • Added the Windows AArch64 rust target to the install targets task.
  • Added the Linux AArch64 rust target to the install targets task.
frontend/scripts/makefile/env.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LucasXu0 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider refactoring the Windows CI jobs to reduce duplication between the x86_64 and arm64 configurations.
  • The Makefile profile production-windows-x86 was not renamed to production-windows-x86_64 for consistency with the development profile rename.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LucasXu0 LucasXu0 force-pushed the arm64_windows branch 3 times, most recently from 681e3d6 to 0075079 Compare April 29, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant