Closed
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request adds support for building AppFlowy for the AArch64 architecture on Windows. It involves updating the CI workflow to include a new job for Windows ARM64 builds, modifying the Makefile configurations to define build environments for Windows AArch64, and adding the AArch64 rust targets to the environment setup scripts. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider refactoring the Windows CI jobs to reduce duplication between the x86_64 and arm64 configurations.
- The Makefile profile
production-windows-x86was not renamed toproduction-windows-x86_64for consistency with the development profile rename.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
681e3d6 to
0075079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Preview
PR Checklist
Summary by Sourcery
Add build and CI support for Windows ARM64 (
aarch64-pc-windows-msvc).Build:
aarch64-pc-windows-msvcRust target during setup.aarch64-unknown-linux-gnuRust target during setup.CI: