fix: allow ':keyword' make mistakes#7905
Conversation
Reviewer's GuideThis pull request enhances the emoji search by allowing continued input (up to 5 characters) even when no results are found. This is implemented by tracking the last fruitless search query with a new state variable, File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @asjqkkkk - I've reviewed your changes - here's some feedback:
- The 5-character limit for allowing continued input on empty emoji search results is hardcoded; consider defining this as a named constant for improved readability and easier modification.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
richardshiue
left a comment
There was a problem hiding this comment.
The change is good, but it seems like it's become too lenient now:
Screen.Recording.2025-05-12.at.2.01.33.PM.mov
This issue has existed since the previous version, and I haven't found a good solution to address it yet |
When inserting an emoji by using “:”, allow the continuation of input with a string of up to 5 characters even if no results are found
Feature Preview
PR Checklist
Summary by Sourcery
Improve emoji search input handling by allowing users to continue typing and exploring emoji suggestions even when initial results are empty
Bug Fixes:
Enhancements: