Skip to content

fix: allow ':keyword' make mistakes#7905

Merged
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
asjqkkkk:fix/desktop/emoji
May 13, 2025
Merged

fix: allow ':keyword' make mistakes#7905
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
asjqkkkk:fix/desktop/emoji

Conversation

@asjqkkkk
Copy link
Collaborator

@asjqkkkk asjqkkkk commented May 9, 2025

When inserting an emoji by using “:”, allow the continuation of input with a string of up to 5 characters even if no results are found

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Improve emoji search input handling by allowing users to continue typing and exploring emoji suggestions even when initial results are empty

Bug Fixes:

  • Prevent premature dismissal of emoji picker when no initial results are found

Enhancements:

  • Extend emoji search input tolerance to allow continued typing up to 5 additional characters
  • Add a 'no results' message when no emojis match the current search query

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 9, 2025

Reviewer's Guide

This pull request enhances the emoji search by allowing continued input (up to 5 characters) even when no results are found. This is implemented by tracking the last fruitless search query with a new state variable, lastSearchedQuery, in _EmojiHandlerState. The emoji picker only dismisses if the user types 5 more characters without finding a match. The UI now displays a localized 'No results' message in this scenario. A scroll operation safety check was also added.

File-Level Changes

Change Details Files
Modified emoji search to tolerate typos by delaying dismissal.
  • Introduced lastSearchedQuery state variable to track the search query when no results are found.
  • Updated _searchEmoji to dismiss the picker only if the current query is 5+ characters longer than lastSearchedQuery.
  • Reset lastSearchedQuery when search results are found again.
frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart
Updated UI to display a localized 'No results' message.
  • Added a 'No results' message display within buildEmojis when the search yields no emojis.
  • Integrated easy_localization for the message text and imported necessary libraries.
  • Adjusted container padding and child rendering logic in build to correctly display the 'No results' message instead of a loading indicator.
frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart
Added safety check for scroll operations.
  • Guarded scrolling operations in _scrollToItem by checking scrollController.hasClients.
frontend/appflowy_flutter/lib/plugins/emoji/emoji_handler.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @asjqkkkk - I've reviewed your changes - here's some feedback:

  • The 5-character limit for allowing continued input on empty emoji search results is hardcoded; consider defining this as a named constant for improved readability and easier modification.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@asjqkkkk asjqkkkk added the v0.9.2 label May 9, 2025
Copy link
Collaborator

@richardshiue richardshiue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good, but it seems like it's become too lenient now:

Screen.Recording.2025-05-12.at.2.01.33.PM.mov

@asjqkkkk
Copy link
Collaborator Author

The change is good, but it seems like it's become too lenient now:

Screen.Recording.2025-05-12.at.2.01.33.PM.mov

This issue has existed since the previous version, and I haven't found a good solution to address it yet

@LucasXu0 LucasXu0 merged commit 1047247 into AppFlowy-IO:main May 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants