Skip to content

fix: permission control doesn't work when opening the page at the first time #8023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucasXu0 merged 16 commits into from
Jun 5, 2025
Merged

fix: permission control doesn't work when opening the page at the first time #8023

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
beb7e95
fix: permission control doesn't work when opening the page at the fir…
LucasXu0 Jun 4, 2025
72551d2
feat: enable tracing events cost time
LucasXu0 Jun 4, 2025
9955522
feat: leave shared page via ... menu
LucasXu0 Jun 4, 2025
ae77fa2
fix: hide the create page button if user is guest
LucasXu0 Jun 4, 2025
6ce36bb
feat: disable publish button if user is a guest
LucasXu0 Jun 4, 2025
2c78acd
feat: add shared user table
LucasXu0 Jun 4, 2025
9e4ffd4
feat: integrate sql into folder manager
LucasXu0 Jun 4, 2025
d250d75
feat: integrate shared user notification
LucasXu0 Jun 4, 2025
bcf87c2
fix: flutter analyze
LucasXu0 Jun 4, 2025
613529f
fix: revert local shared user data
LucasXu0 Jun 4, 2025
675a8ba
fix: disable share button on mobile if user is a guest
LucasXu0 Jun 4, 2025
8b4b9b1
feat: save the shared user data
LucasXu0 Jun 4, 2025
e05bcd8
feat: integrate pro plan workflow into share menu
LucasXu0 Jun 4, 2025
5877cff
chore: format code
LucasXu0 Jun 4, 2025
d1e28fc
feat: disable share menu in local mode
LucasXu0 Jun 4, 2025
1b20289
chore: format code
LucasXu0 Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .../features/page_access_level/data/repositories/rust_page_access_level_repository_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class RustPageAccessLevelRepositoryImpl implements PageAccessLevelRepository {
final result = await ViewBackendService.getView(pageId);
return result.fold(
(view) {
Log.info('get view success: ${view.id}');
Log.debug('get view(${view.id}) success');
return FlowyResult.success(view);
},
(error) {
Expand All @@ -33,7 +33,7 @@ class RustPageAccessLevelRepositoryImpl implements PageAccessLevelRepository {
final result = await ViewBackendService.lockView(pageId);
return result.fold(
(_) {
Log.info('lock view success: $pageId');
Log.debug('lock view($pageId) success');
return FlowyResult.success(null);
},
(error) {
Expand All @@ -48,7 +48,7 @@ class RustPageAccessLevelRepositoryImpl implements PageAccessLevelRepository {
final result = await ViewBackendService.unlockView(pageId);
return result.fold(
(_) {
Log.info('unlock view success: $pageId');
Log.debug('unlock view($pageId) success');
return FlowyResult.success(null);
},
(error) {
Expand All @@ -67,6 +67,7 @@ class RustPageAccessLevelRepositoryImpl implements PageAccessLevelRepository {
(s) => s,
(_) => null,
);

if (user == null) {
return FlowyResult.failure(
FlowyError(
Expand Down Expand Up @@ -100,7 +101,7 @@ class RustPageAccessLevelRepositoryImpl implements PageAccessLevelRepository {
)
?.accessLevel
.shareAccessLevel ??
ShareAccessLevel.readAndWrite;
ShareAccessLevel.readOnly;

Log.debug('current user access level: $accessLevel, in page: $pageId');

Expand All @@ -112,7 +113,7 @@ class RustPageAccessLevelRepositoryImpl implements PageAccessLevelRepository {
);

// return the read and write access level if the user is not found
Copy link
Contributor

@sourcery-ai sourcery-ai bot Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Update or remove outdated inline comment

The inline comment is now inaccurate; please update it to match the current return value or remove it.

return FlowyResult.success(ShareAccessLevel.readAndWrite);
return FlowyResult.success(ShareAccessLevel.readOnly);
},
);
}
Expand Down
3 changes: 1 addition & 2 deletions frontend/appflowy_flutter/lib/features/page_access_level/logic/page_access_level_state.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ class PageAccessLevelState {
isLocked: false,
lockCounter: 0,
sectionType: SharedSectionType.public,
accessLevel: ShareAccessLevel
.readAndWrite, // replace it with readOnly if we support offline.
accessLevel: ShareAccessLevel.readOnly,
);

const PageAccessLevelState({
Expand Down
5 changes: 2 additions & 3 deletions frontend/appflowy_flutter/lib/features/shared_section/presentation/shared_section.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:appflowy/features/shared_section/data/repositories/local_shared_pages_repository_impl.dart';
import 'package:appflowy/features/shared_section/data/repositories/rust_shared_pages_repository_impl.dart';
import 'package:appflowy/features/shared_section/logic/shared_section_bloc.dart';
import 'package:appflowy/features/shared_section/presentation/widgets/refresh_button.dart';
import 'package:appflowy/features/shared_section/presentation/widgets/shared_page_list.dart';
Expand Down Expand Up @@ -30,8 +30,7 @@ class SharedSection extends StatelessWidget {

@override
Widget build(BuildContext context) {
// final repository = RustSharePagesRepositoryImpl();
final repository = LocalSharedPagesRepositoryImpl();
final repository = RustSharePagesRepositoryImpl();

return BlocProvider(
create: (_) => SharedSectionBloc(
Expand Down
6 changes: 3 additions & 3 deletions frontend/appflowy_flutter/lib/plugins/shared/share/share_button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:appflowy/features/share_tab/data/repositories/local_share_with_user_repository_impl.dart';
import 'package:appflowy/features/share_tab/data/repositories/rust_share_with_user_repository_impl.dart';
import 'package:appflowy/features/share_tab/logic/share_tab_bloc.dart';
import 'package:appflowy/features/workspace/logic/workspace_bloc.dart';
import 'package:appflowy/generated/locale_keys.g.dart';
Expand Down Expand Up @@ -44,8 +44,8 @@ class ShareButton extends StatelessWidget {
),
BlocProvider(
create: (context) => ShareTabBloc(
// repository: RustShareWithUserRepositoryImpl(),
repository: LocalShareWithUserRepositoryImpl(),
repository: RustShareWithUserRepositoryImpl(),
// repository: LocalShareWithUserRepositoryImpl(),
pageId: view.id,
workspaceId: workspaceId,
)..add(ShareTabEvent.initialize()),
Expand Down
Loading