Skip to content

fix: regression in handling on non-standard URLs on Windows #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: regression in handling on non-standard URLs on Windows #8070

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d038f1
fix: regression in handling on non-standard URLs on Windows
asjqkkkk Jun 17, 2025
15ba348
Merge branch 'main' into fix/issue/8050
asjqkkkk Jul 14, 2025
1269b5b
chore: typo issue
asjqkkkk Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ import 'package:open_filex/open_filex.dart';
import 'package:string_validator/string_validator.dart';
import 'package:universal_platform/universal_platform.dart';
import 'package:url_launcher/url_launcher.dart' as launcher;
// ignore: implementation_imports
import 'package:appflowy_editor/src/editor/util/link_util.dart'
show isCustomUrL;

typedef OnFailureCallback = void Function(Uri uri);

Expand Down Expand Up @@ -39,10 +42,12 @@ Future<bool> afLaunchUri(
);
}

// on Linux or Android or Windows, add http scheme to the url if it is not present
// on Linux or Android, add http scheme to the url if it is not present
Copy link
Contributor

@sourcery-ai sourcery-ai bot Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Comment doesn’t reflect Windows condition

Please update the comment to include Windows, as the logic applies to Windows when the URL is not custom.

final isNotCustomUrlOnWidows =
UniversalPlatform.isWindows && !isCustomUrL(url);
if ((UniversalPlatform.isLinux ||
UniversalPlatform.isAndroid ||
UniversalPlatform.isWindows) &&
isNotCustomUrlOnWidows) &&
!isURL(url, {'require_protocol': true})) {
uri = Uri.parse('https://$url');
}
Expand Down
Loading