-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
chore: upgrade AGP version to 8.1.0 #8119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR upgrades the Android Gradle Plugin to 8.1.0 and Gradle wrapper to 8.1, bumps compileSdk levels, and adds required namespace and compile option configurations to support the updated toolchain across multiple Android modules. Class diagram for updated Android module build configurationsclassDiagram
class AppModule {
+compileSdkVersion: 35
+ndkVersion: "24.0.8215888"
}
class BackendModule {
+compileSdkVersion: 33
+namespace: 'com.plugin.appflowy_backend'
+compileOptions: Java 1.8
+kotlinOptions: JVM 1.8
}
class InfraUIModule {
+compileSdkVersion: 33
+namespace: 'com.example.flowy_infra_ui'
}
AppModule <|-- BackendModule
AppModule <|-- InfraUIModule
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
- AGP 8.1 requires JDK 11+, please ensure your local and CI environments are using Java 11 to avoid build failures.
- The flowy_infra_ui module adds compileOptions but is missing a kotlinOptions jvmTarget block—add it to keep the Kotlin JVM target consistent across modules.
- Double-check that the namespaces ('com.plugin.appflowy_backend' and 'com.example.flowy_infra_ui') correctly match your package structure to prevent resource/R-class conflicts.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- AGP 8.1 requires JDK 11+, please ensure your local and CI environments are using Java 11 to avoid build failures.
- The flowy_infra_ui module adds compileOptions but is missing a kotlinOptions jvmTarget block—add it to keep the Kotlin JVM target consistent across modules.
- Double-check that the namespaces ('com.plugin.appflowy_backend' and 'com.example.flowy_infra_ui') correctly match your package structure to prevent resource/R-class conflicts.
## Individual Comments
### Comment 1
<location> `frontend/appflowy_flutter/android/gradle/wrapper/gradle-wrapper.properties:3` </location>
<code_context>
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-all.zip
networkTimeout=10000
validateDistributionUrl=true
</code_context>
<issue_to_address>
Switching to gradle-8.1-all.zip increases distribution size.
The '-all' distribution includes sources and docs. If you don't need these, use '-bin' to minimize download size.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-all.zip
=======
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-bin.zip
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -1,6 +1,6 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Switching to gradle-8.1-all.zip increases distribution size.
The '-all' distribution includes sources and docs. If you don't need these, use '-bin' to minimize download size.
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip | |
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-bin.zip |
b340813 to
7db2d10
Compare
Feature Preview
PR Checklist
Summary by Sourcery
Update Android build tooling and configuration by upgrading AGP and Gradle versions, raising compileSdk levels, and aligning Java/Kotlin compilation settings alongside adding module namespaces.
Enhancements:
Build: