Skip to content

Conversation

@codjix
Copy link

@codjix codjix commented Aug 20, 2025

Update Exec value to the right executable path to fix app doesn't show after installation with deb or rpm files

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Bug Fixes:

  • Correct the .desktop Exec path to point to the actual AppFlowy executable so the app shows up in menus post-installation.

Update Exec value to the right executable path to fix app doesn't show after installation with deb or rpm files
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR corrects the Exec entry in the AppFlowy.desktop launcher under the Debian distribution scripts to reference the proper installation path, ensuring the app launches correctly after DEB or RPM installations.

File-Level Changes

Change Details Files
Updated Exec value to full system path
  • Replaced generic appflowy command with /usr/bin/appflowy in Exec entry
  • Aligned launcher file with actual binary installation location
frontend/scripts/linux_distribution/deb/AppFlowy.desktop

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LucasXu0
Copy link
Collaborator

We created a symlink in the postinst script. Doesn't it work on your side?

#!/usr/bin/env bash
if [ -e /usr/bin/AppFlowy ]; then
    echo "Symlink already exists, skipping."
else
    echo "Creating Symlink in /usr/bin/appflowy"
    ln -s /usr/lib/AppFlowy/AppFlowy /usr/bin/AppFlowy
    ln -s /usr/lib/AppFlowy/launcher.sh /usr/bin/AppFlowyLauncher.sh
fi

@codjix
Copy link
Author

codjix commented Aug 21, 2025

We created a symlink in the postinst script. Doesn't it work on your side?

#!/usr/bin/env bash
if [ -e /usr/bin/AppFlowy ]; then
    echo "Symlink already exists, skipping."
else
    echo "Creating Symlink in /usr/bin/appflowy"
    ln -s /usr/lib/AppFlowy/AppFlowy /usr/bin/AppFlowy
    ln -s /usr/lib/AppFlowy/launcher.sh /usr/bin/AppFlowyLauncher.sh
fi

The postinst script doesn't exist in the .rpm releases. Tested the latest AppFlowy-0.9.7-linux-x86_64.rpm and the app icon doesn't show up unless I edit the AppFlowy.desktop manually.

@codjix codjix closed this by deleting the head repository Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants