Skip to content

Conversation

@RishiAhuja
Copy link
Contributor

@RishiAhuja RishiAhuja commented Oct 7, 2025

Feature Preview

This PR improves the user experience in the shortcuts settings page by fixing layout spacing issues and enhancing hover effects for better visual feedback.
fixes #8222

Issue 1 fixed

Screenshot 2025-10-07 at 10 46 37 AM

Issue 2 fixed

Screenshot 2025-10-07 at 10 46 54 AM

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Improve the visual feedback and layout spacing in the shortcuts settings UI

Enhancements:

  • Add persistent hover state and custom hover color to the reset button
  • Update reset button to dynamically change icon and text colors on hover
  • Adjust flex ratios in shortcut setting tiles to give more space to keybinding fields

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Enhanced the shortcuts settings UI by implementing more responsive hover interactions on the reset button and optimizing flex ratios for better spacing in shortcut tiles.

File-Level Changes

Change Details Files
Enhanced hover feedback for the reset button
  • Added resetHoverOnRebuild flag to preserve hover state
  • Introduced HoverStyle with custom hoverColor
  • Switched to builder pattern to access isHovering
  • Applied conditional coloring to icon and text based on hover state
frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart
Refined layout flex proportions for shortcut tiles
  • Increased label area flex to 3 for more space
  • Set keybinding area flex to 2 for better balance
frontend/appflowy_flutter/lib/workspace/presentation/settings/pages/settings_shortcuts_view.dart

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2025

CLA assistant check
All committers have signed the CLA.

@RishiAhuja RishiAhuja changed the title Feature/settings shortcuts UI improvements 8222 Fix settings shortcuts UI improvements 8222 Oct 7, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@MayurSMahajan
Copy link
Collaborator

MayurSMahajan commented Oct 7, 2025

To me the changes look good. About the first issue, I was expecting the label and keys to be spaced like space-between. As such:
Screenshot 2025-10-07 at 11 12 42 AM

About the code, I am a little rusty with AppFlowy's code since I have not done any contributions since some time. But someone from the team will definitely look at your PR so don't worry.

Thank you for your contribution.

@RishiAhuja
Copy link
Contributor Author

@MayurSMahajan Thanks for looking into the PR!
I will try to do the suggested improvements as soon as possible about the Issue 1.

@RishiAhuja
Copy link
Contributor Author

I've made changes as suggested by @MayurSMahajan. Here are some screenshots.
Screenshot 2025-10-07 at 2 22 09 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Settings btn not consistent with other btns, key tiles layout is weird

3 participants