fix: preserve pages when moving document blocks - #8999
Open
kaluli123123 wants to merge 2 commits into
Open
Conversation
Contributor
Reviewer's GuideUpdates sub-page transaction handling to distinguish actual deletions from block moves and sidebar reparenting, preserving views that remain referenced or have already changed parents. Adds a unit test for recursive nested-reference detection. Sequence diagram for preserving sub-pages during block removalsequenceDiagram
participant Editor as EditorState
participant Handler as SubPageTransactionHandler
participant Backend as ViewBackendService
Editor->>Handler: _subPageDeleted(context, editorState, node, parentViewId)
Handler->>Editor: documentContainsSubPageReference(root, viewId)
alt another block references viewId
Editor-->>Handler: true
Handler-->>Editor: preserve view
else no remaining reference
Handler->>Backend: getView(viewId)
Backend-->>Handler: view
alt view.parentViewId != parentViewId
Handler-->>Editor: preserve reparented view
else same parent
Handler->>Backend: deleteView(viewId: viewId)
Backend-->>Handler: result
end
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sub_pageblocks as references, so other blocks sharingview_iddo not suppress deletionCloses #7588
Validation
flutter test --no-pub test/unit_test/document/sub_page_transaction_handler_test.dart— 1 test passedflutter analyze --no-pub .— no issues foundgit diff --checkpassValidated with Flutter 3.27.4 on macOS arm64.