fix: consume confirmation dialog key events - #9001
Open
kaluli123123 wants to merge 3 commits into
Open
Conversation
Contributor
Reviewer's GuideUpdates the confirmation dialog’s keyboard event handling to use Focus and explicitly consume Escape and Enter events, preventing unhandled-key system alert sounds while preserving existing actions and close semantics. Sequence diagram for confirmation dialog key handlingsequenceDiagram
actor User
participant Dialog as ConfirmPopup
participant Navigator
User->>Dialog: Escape KeyDownEvent
Dialog->>Dialog: _handleKeyEvent(node, event)
Dialog->>Navigator: pop()
Dialog-->>User: KeyEventResult.handled
User->>Dialog: Enter KeyUpEvent
Dialog->>Dialog: _handleKeyEvent(node, event)
Dialog->>Dialog: onConfirm(context)
opt closeOnAction
Dialog->>Navigator: pop()
end
Dialog-->>User: KeyEventResult.handled
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7342
Validation
flutter test --no-pub test/widget_test/confirm_dialog_test.dart— 1 test passedflutter analyze --no-pub .— no issues foundgit diff --checkpassValidated with Flutter 3.27.4 on macOS arm64. The system alert sound itself was not exercised in a packaged app.