Skip to content

Use mimalloc to speed up launch time #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
probonopd merged 4 commits into from
Mar 6, 2025
Merged

Use mimalloc to speed up launch time #120

probonopd merged 4 commits into from
Mar 6, 2025

Conversation

@probonopd
Copy link
Member

@probonopd probonopd commented Mar 5, 2025 •
edited
Loading

Closes #116, 18% speedup in launch time.

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

Build for testing:
artifacts x86_64
artifacts i686
artifacts armhf
Use at your own risk.

@probonopd
Copy link
Member Author

probonopd commented Mar 5, 2025 •
edited
Loading

Hello @TheAssassin, do you have any idea why one of the builds fails in Docker but succeeds in chroot?
Maybe you know what is going on? Alone I'd be lost here and would have to ditch Docker.

Edit: Just restarted the failed build to see whether it was just an intermittent error. Probably more wishful thinking than understanding what's going on...

@probonopd probonopd mentioned this pull request Mar 5, 2025
Closed
@github-actions
Copy link

github-actions bot commented Mar 5, 2025

Build for testing:
artifacts x86_64
artifacts i686
artifacts armhf
artifacts aarch64
Use at your own risk.

@Samueru-sama
Copy link

Samueru-sama commented Mar 5, 2025

Indeed, it fixes the issue 👀

image

That's an 18% speedup in the launch time.

@probonopd probonopd requested a review from TheAssassin March 5, 2025 21:33
@probonopd
Copy link
Member Author

probonopd commented Mar 5, 2025

Thank you very much @Samueru-sama.

@probonopd probonopd changed the title mimalloc-dev Use mimalloc to speed up launch time Mar 5, 2025
@TheAssassin
Copy link
Member

TheAssassin commented Mar 6, 2025

Strange that just linking to this libraries improves memory allocation. But then again, we'll take it.

TheAssassin
TheAssassin approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash during merge.

@probonopd
Copy link
Member Author

probonopd commented Mar 6, 2025

...as always :)

@probonopd probonopd merged commit 2df896e into main Mar 6, 2025
18 checks passed
@probonopd probonopd deleted the mimalloc branch March 6, 2025 22:52
@Drsheppard01
Copy link

Drsheppard01 commented Mar 10, 2025

New release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheAssassin TheAssassin TheAssassin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Very likely 25% increase in launch time due to statically linked musl

5 participants

@probonopd @Samueru-sama @TheAssassin @Drsheppard01