Do not use sudo when already root, do not use find for copying build products #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove dependency on sudo when already running as root - not available in all environments. - Remove unnecessary use of `find` to copy build artifacts as build-runtime.sh already puts them in a known place and the find command chokes under the current Ubuntu kernel while iterating over the /proc/ filesystem.
|
Build for testing: |
probonopd
changed the title
TheAssassin
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on sudo when already running as root - not available in all environments.
Remove unnecessary use of
findto copy build artifacts as build-runtime.sh already puts them in a known place and the find command chokes under the current Ubuntu kernel while iterating over the /proc/ filesystem.