Skip to content

fix: ios port forwarding for real device #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudharsan-selvaraj merged 2 commits into from
Feb 17, 2025
Merged

fix: ios port forwarding for real device #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71b3892
fix: ios port forwarding for real device
sudharsan-selvaraj Feb 17, 2025
01aa852
update package lock
sudharsan-selvaraj Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/modules
Open in desktop
Submodule modules updated from d58a06 to 3b8b38
13 changes: 9 additions & 4 deletions src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,20 +354,25 @@ class DevicePlugin extends BasePlugin {
await EventBus.fire(
new BeforeSessionCreatedEvent({ device, sessionType: sessionType, caps }),
);

if (device.platform === 'ios' && device.realDevice) {

session = await next();

if (
device.platform === 'ios' &&
device.realDevice &&
device.nodeId === DevicePlugin.NODE_ID
) {
log.info(`📱 Forwarding ios port to real device ${device.udid} for manual interaction`);
try {
await DEVICE_CONNECTIONS_FACTORY.requestConnection(device.udid, device.mjpegServerPort, {
usePortForwarding: true,
devicePort: device.mjpegServerPort,
});
} catch(err){
} catch (err) {
/* Not required for now as the port forwarding is handled by xcuitest river itself */
log.warn(`Error while forwarding ios port to real device ${device.udid}. Error: ${err}`);
}
}
session = await next();

debugLog(`📱 Session response: ${JSON.stringify(session)}`);
}
Expand Down
Loading