Skip to content

fix: fix #1909 #1895 starting session when go-ios is provided#1915

Merged
saikrishna321 merged 2 commits intomainfrom
fix-go-ios-tunnel
Oct 28, 2025
Merged

fix: fix #1909 #1895 starting session when go-ios is provided#1915
saikrishna321 merged 2 commits intomainfrom
fix-go-ios-tunnel

Conversation

@saikrishna321
Copy link
Member

This pull request refactors how the go-ios tunnel is started for iOS devices with SDK version 17 or higher. The logic for starting the tunnel has been moved from IOSDeviceManager into a dedicated function in goIOSTracker, and the device state now includes the port used for the go-ios agent. This makes the code more modular, improves logging, and ensures that tunnels are only started when appropriate.

Go-iOS tunnel management and SDK version checks:

  • Refactored the logic for starting the go-ios tunnel: it is now handled by a new startTunnel function in goIOSTracker.ts, which checks the SDK version, environment variable, and agent port before starting the tunnel. Improved logging and error handling are included. [1] [2]
  • The tunnel is now started only for devices with SDK >= 17 and when the GO_IOS environment variable is set, using the port assigned in the device info. [1] [2]

Device info and state changes:

  • The device state now includes a new goIOSAgentPort property, which is generated if the GO_IOS environment variable is set, and is used for the tunnel. This is reflected in the IDevice interface and device info construction. [1] [2] [3]

Code organization and imports:

  • Cleaned up and reordered imports in IOSDeviceManager.ts to improve readability and maintainability.

Submodule update:

  • Updated the src/modules submodule to a new commit.

saikrishna321 and others added 2 commits October 28, 2025 13:27
Co-authored-by: SrinivasanTarget <srinivasan.sekar1990@gmail.com>
Co-authored-by: SrinivasanTarget <srinivasan.sekar1990@gmail.com>
@saikrishna321 saikrishna321 merged commit c446851 into main Oct 28, 2025
5 checks passed
saikrishna321 pushed a commit that referenced this pull request Oct 28, 2025
## [11.1.2](v11.1.1...v11.1.2) (2025-10-28)

### Bug Fixes

* fix [#1909](#1909) [#1895](#1895) starting session when go-ios is provided ([#1915](#1915)) ([c446851](c446851))
@github-actions
Copy link

🎉 This PR is included in version 11.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@saikrishna321 saikrishna321 deleted the fix-go-ios-tunnel branch December 12, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant