fix: fix #1909 #1895 starting session when go-ios is provided#1915
Merged
saikrishna321 merged 2 commits intomainfrom Oct 28, 2025
Merged
fix: fix #1909 #1895 starting session when go-ios is provided#1915saikrishna321 merged 2 commits intomainfrom
saikrishna321 merged 2 commits intomainfrom
Conversation
Co-authored-by: SrinivasanTarget <srinivasan.sekar1990@gmail.com>
Co-authored-by: SrinivasanTarget <srinivasan.sekar1990@gmail.com>
saikrishna321
pushed a commit
that referenced
this pull request
Oct 28, 2025
|
🎉 This PR is included in version 11.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the go-ios tunnel is started for iOS devices with SDK version 17 or higher. The logic for starting the tunnel has been moved from
IOSDeviceManagerinto a dedicated function ingoIOSTracker, and the device state now includes the port used for the go-ios agent. This makes the code more modular, improves logging, and ensures that tunnels are only started when appropriate.Go-iOS tunnel management and SDK version checks:
startTunnelfunction ingoIOSTracker.ts, which checks the SDK version, environment variable, and agent port before starting the tunnel. Improved logging and error handling are included. [1] [2]GO_IOSenvironment variable is set, using the port assigned in the device info. [1] [2]Device info and state changes:
goIOSAgentPortproperty, which is generated if theGO_IOSenvironment variable is set, and is used for the tunnel. This is reflected in theIDeviceinterface and device info construction. [1] [2] [3]Code organization and imports:
IOSDeviceManager.tsto improve readability and maintainability.Submodule update:
src/modulessubmodule to a new commit.