fix: Added support for descendant within scroll #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how Flutter locators are handled in the WDIO Flutter service, particularly to support more complex finder strategies such as descendants and ancestors. The main changes enhance the flexibility of the locator object and update the scroll utility to work with these more advanced selectors.
Locator and Finder Handling Improvements:
Locatortype now supports both avalue(optional) and aselectorproperty, allowing it to represent both simple and complex finders.registerLocatorsfunction now distinguishes between simple and complex finders (likeflutterByDescendantandflutterByAncestor), assigning their configuration to the appropriate property (selectorfor complex,valuefor simple).Method and API Updates:
flutterScrollTillVisiblemethod now accepts either aWebdriverIO.Elementor aFlutter.Locatoras itsfinderparameter, making it compatible with more types of finders.flutterScrollTillVisiblenormalizes thefinderto the correct format for the server, ensuring compatibility regardless of the finder type passed in.Test Coverage: