Skip to content

Conversation

@saikrishna321
Copy link
Member

@saikrishna321 saikrishna321 commented Sep 17, 2025

This pull request introduces improvements to how Flutter locators are handled in the WDIO Flutter service, particularly to support more complex finder strategies such as descendants and ancestors. The main changes enhance the flexibility of the locator object and update the scroll utility to work with these more advanced selectors.

Locator and Finder Handling Improvements:

  • The Locator type now supports both a value (optional) and a selector property, allowing it to represent both simple and complex finders.
  • The registerLocators function now distinguishes between simple and complex finders (like flutterByDescendant and flutterByAncestor), assigning their configuration to the appropriate property (selector for complex, value for simple).

Method and API Updates:

  • The flutterScrollTillVisible method now accepts either a WebdriverIO.Element or a Flutter.Locator as its finder parameter, making it compatible with more types of finders.
  • Internally, flutterScrollTillVisible normalizes the finder to the correct format for the server, ensuring compatibility regardless of the finder type passed in.

Test Coverage:

  • The test for "Scroll until visible with Descendant" is now enabled, ensuring that the new complex finder support is exercised in end-to-end tests.

@saikrishna321 saikrishna321 changed the title Added support for descendant within scroll fix: Added support for descendant within scroll Sep 17, 2025
Co-authored-by: SrinivasanTarget <[email protected]>
@saikrishna321 saikrishna321 merged commit fbae4c3 into main Sep 17, 2025
4 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 17, 2025
## [1.4.1](v1.4.0...v1.4.1) (2025-09-17)

### Bug Fixes

* Added support for descendant within scroll ([#141](#141)) ([fbae4c3](fbae4c3))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant