Saving the previous proxy state #75
Conversation
|
up |
| const host = proxy ? `${proxy.ip}:${proxy.port}` : ':0'; | ||
| const host = proxy?.ip ? `${proxy.ip}:${proxy.port}` : ':0'; | ||
|
|
||
| if (realDevice && proxy) { |
There was a problem hiding this comment.
Should we also update the condition here to check if the proxy has a valid ip/port property?
There was a problem hiding this comment.
Global proxies are defined in the "host:port" format, so I don’t think any additional checks are necessary.
src/plugin.ts
Outdated
| } | ||
| const realDevice = await isRealDevice(adb, deviceUDID); | ||
|
|
||
| this.previousGlobalProxy = await getGlobalProxyValue(adb, deviceUDID) |
There was a problem hiding this comment.
Storing the previous proxy state in the class instance can lead to issues when tests run in parallel.
A better approach is to store the current proxy URL within the session’s proxy object, ensuring it remains unique to each device session.
There was a problem hiding this comment.
Fixed - previous proxy state saved in current proxy object
|
Hello, Using the device farm plugin as example, we created a PR with plugin argument to use a custom certificate folder: The version is still 1.0.2 in this PR but the release is still stuck to 1.0.1: Best regards, |
|
@sudharsan-selvaraj please review |
3 participants
What's new