-
Notifications
You must be signed in to change notification settings - Fork 2
Bugfix/32 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eduardodudu
wants to merge
10
commits into
main
Choose a base branch
from
bugfix/32
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bugfix/32 #42
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1190436
First approach on IntersectionObserver
Eduardodudu 687d808
Update with manual function
Eduardodudu 9a43a60
update example structure
Eduardodudu 2aa29cc
Add unit test with shinytest2
Eduardodudu d5ddb83
Fix lint
Eduardodudu 2aea97f
remove bslib from test helper
Eduardodudu dd98767
Merge branch 'main' into bugfix/32
Eduardodudu b54ace3
Add documentation for toggle empty state
Eduardodudu b8d7584
Update reference of gif
Eduardodudu cd2f3e3
Update unit test
Eduardodudu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,6 +56,14 @@ describe("EmptyStateManager", { | |
| expect_null(app$get_html(selector = ".empty-state-content")) | ||
| app$stop() | ||
| }) | ||
|
|
||
| it("checks the empty state component follows slider from id", { | ||
| app <- shinytest2::AppDriver$new(test_slider_app(), name = "slide_tag") | ||
| app$expect_values() | ||
| app$click("toggle_pannel") | ||
| app$expect_values() | ||
| app$stop() | ||
| }) | ||
| }) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test is useless.
|
||
|
|
||
| describe("use_empty_state()", { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the name of the function to follow camel case, instead of a weird hybrid.
updateElementPositionshould work here.