Skip to content

chore: eas build 설정 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mark77234 merged 1 commit into from
Dec 27, 2025
Merged

chore: eas build 설정 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions frontend/app.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ export default ({ config }: ConfigContext): ExpoConfig => ({
name: 'dailyfate',
slug: 'dailyfate',
version: '1.0.0',
extra: {
eas: {
projectId: '7eaf22a0-8a86-4d38-96f4-5c8eb183393b',
},
},
orientation: 'portrait',
icon: './assets/icon.png',
userInterfaceStyle: 'light',
Expand All @@ -15,17 +20,25 @@ export default ({ config }: ConfigContext): ExpoConfig => ({
},
assetBundlePatterns: ['**/*'],
ios: {
...config.ios,
supportsTablet: true,
bundleIdentifier: 'com.dailyfate.frontend',
infoPlist: {
...config.ios?.infoPlist,
ITSAppUsesNonExemptEncryption: false,
},
},
android: {
...config.android,
adaptiveIcon: {
...(config.android?.adaptiveIcon ?? {}),
foregroundImage: './assets/adaptive-icon.png',
backgroundColor: '#ffffff',
},
package: 'com.dailyfate.frontend',
},
web: {
...config.web,
favicon: './assets/favicon.png',
},
scheme: 'frontend',
Expand Down
30 changes: 0 additions & 30 deletions frontend/app.json
View file
Open in desktop

This file was deleted.

30 changes: 25 additions & 5 deletions frontend/eas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,44 @@
{
"cli": {
"version": ">= 13.2.1",
"appVersionSource": "remote"
"version": ">= 11.0.0",
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI version requirement has been downgraded from ">= 13.2.1" to ">= 11.0.0". This is a significant downgrade (approximately 2 major versions) and may result in missing newer features, bug fixes, and security patches available in more recent EAS CLI versions. Consider using a more recent version requirement unless there's a specific compatibility reason for this downgrade.

Suggested change
"version": ">= 11.0.0",
"version": ">= 13.2.1",

Copilot uses AI. Check for mistakes.
"appVersionSource": "local"
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appVersionSource has been changed from "remote" to "local". This means version numbers will now be managed locally in your configuration files rather than remotely on EAS servers. Ensure that you have a process in place to manually increment version numbers for each release, as automatic version management will no longer be handled by EAS.

Suggested change
"appVersionSource": "local"
"appVersionSource": "remote"

Copilot uses AI. Check for mistakes.
},
"build": {
"development": {
"developmentClient": true,
"distribution": "internal"
"distribution": "internal",
"android": {
"buildType": "apk"
},
"ios": {
"simulator": true
}
},
"preview": {
"distribution": "internal",
"android": {
"buildType": "apk"
},
"ios": {
"simulator": true
}
},
"production": {
"autoIncrement": true
"distribution": "store",
"android": {
"buildType": "app-bundle"
},
"ios": {
"simulator": false
}
Comment on lines 26 to +33
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The production build configuration has removed the "autoIncrement" setting which was previously configured. This removal, combined with the change to "local" appVersionSource, means version numbers will no longer be automatically incremented for production builds. This could lead to version conflicts or forgotten version updates when releasing to the store.

Copilot uses AI. Check for mistakes.
}
},
"submit": {
"production": {}
"production": {
"ios": {
"appleId": "mark77234@icloud.com",
"appleTeamId": "GQ89YG5G9R"
Comment on lines +39 to +40
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Apple ID email address "mark77234@icloud.com" and Apple Team ID "GQ89YG5G9R" are hardcoded in the configuration file. These sensitive credentials should not be committed to version control as they can be publicly exposed. Consider using environment variables or a secure credential management system instead. For example, these values should be stored in a .env file or injected during the build process through EAS secrets.

Suggested change
"appleId": "mark77234@icloud.com",
"appleTeamId": "GQ89YG5G9R"

Copilot uses AI. Check for mistakes.
}
}
}
}
Loading