Skip to content

Conversation

@mark77234
Copy link
Collaborator

작업내용

  • 전체 UI 업데이트 작업

Copilot AI review requested due to automatic review settings December 29, 2025 07:39
@mark77234 mark77234 linked an issue Dec 29, 2025 that may be closed by this pull request
@mark77234 mark77234 self-assigned this Dec 29, 2025
@mark77234 mark77234 merged commit 0c1e5c3 into dev Dec 29, 2025
2 of 3 checks passed
@mark77234 mark77234 deleted the feat/7 branch December 29, 2025 07:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a comprehensive UI update for the frontend, introducing Korean Noto Serif fonts, redesigning the user interface with larger text sizes, replacing text inputs with wheel picker modals, and updating spacing and styling throughout the application.

  • Integrated Noto Serif KR font family with multiple weights (Regular, SemiBold, Bold, ExtraBold)
  • Redesigned UserInfoForm with custom wheel picker components replacing direct text inputs for birthdate, birth time, and notification time selection
  • Updated typography sizes and spacing across LoginScreen, SettingsSheet, and CalendarPage

Reviewed changes

Copilot reviewed 9 out of 14 changed files in this pull request and generated 18 comments.

Show a summary per file
File Description
frontend/tailwind.config.js Added Noto Serif KR font family configurations for Tailwind CSS
frontend/package.json Added dependencies for Noto Serif KR fonts and expo-font
frontend/pnpm-lock.yaml Updated lock file with new font dependencies
frontend/app.config.ts Bumped app version from 1.0.0 to 1.0.1
frontend/app/_layout.tsx Integrated font loading logic with useFonts hook
frontend/app/index.tsx Updated login flow logic, removed onSignUpSuccess callback, and added useEffect for sign-out state cleanup
frontend/src/components/UserInfoForm.tsx Major refactoring: replaced text inputs with wheel picker modals, added date/time parsing utilities, and updated styling
frontend/src/components/SettingsSheet.tsx Updated spacing, added safe area insets, and fixed duplicate background color classes
frontend/src/components/LoginScreen.tsx Updated text sizes, spacing, placeholder text, and removed unused onSignUpSuccess prop usage
frontend/src/components/CalendarPage.tsx Applied Noto font classes alongside existing font-serif classes and added quotation marks to fortune overview
Files not reviewed (1)
  • frontend/pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

frontend/src/components/SettingsSheet.tsx:13

  • Unused import Switch.
import {
  ActivityIndicator,
  Alert,
  KeyboardAvoidingView,
  Modal,
  Platform,
  Pressable,
  Switch,
  Text,
  TextInput,
  View,
} from 'react-native';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +104 to +105
<View className="p-4 ">
<View className="w-full max-w-xl gap-6 rounded-2xl bg-white p-5 ">
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a trailing space in the className. This should be removed for cleaner code.

Suggested change
<View className="p-4 ">
<View className="w-full max-w-xl gap-6 rounded-2xl bg-white p-5 ">
<View className="p-4">
<View className="w-full max-w-xl gap-6 rounded-2xl bg-white p-5">

Copilot uses AI. Check for mistakes.
{month}
</Text>
<Text className="font-serif mb-1.5 ml-1.5 text-base text-gray-500"></Text>
<Text className="font-serif mb-1.5 ml-1.5 text-base text-gray-500 font-noto">
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using both font-serif and font-noto classes on the same element is redundant. Only one font-family declaration should be used. Consider removing font-serif since font-noto is the intended font.

Copilot uses AI. Check for mistakes.
<View className="items-end">
<Text className="font-serif text-3xl font-bold" style={{ color: accentColor }}>
<Text
className="font-serif text-3xl font-bold font-noto"
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using both font-serif and font-noto classes on the same element is redundant. Only one font-family declaration should be used. Consider removing font-serif since font-noto is the intended font.

Copilot uses AI. Check for mistakes.
value={username}
onChangeText={setUsername}
placeholder="아이디"
placeholder="[email protected]"
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the placeholder text. "exmaple" should be "example".

Suggested change
placeholder="exmaple@mail.com"
placeholder="example@mail.com"

Copilot uses AI. Check for mistakes.
내 정보
</Text>
<View className="overflow-hidden rounded-xl border border-gray-200 bg-white">
<View className="overflow-hidden rounded-xl border border-gray-200 bg-white ">
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra trailing space in the className after "bg-white". This is unnecessary and should be removed for cleaner code.

Suggested change
<View className="overflow-hidden rounded-xl border border-gray-200 bg-white ">
<View className="overflow-hidden rounded-xl border border-gray-200 bg-white">

Copilot uses AI. Check for mistakes.
<Text className="font-serif text-lg font-bold text-gray-900 font-noto-semibold">{label}</Text>
</View>
<Text className="font-serif text-[15px] leading-6 text-gray-600">{value}</Text>
<Text className="font-serif text-[15px] leading-6 text-gray-600 font-noto">{value}</Text>
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using both font-serif and font-noto classes on the same element is redundant. Only one font-family declaration should be used. Consider removing font-serif since font-noto is the intended font.

Copilot uses AI. Check for mistakes.
className="items-center justify-center"
>
<Text
className={`${isSelected ? 'text-gray-900' : 'text-gray-400'} ${itemTextClassName} `}
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a trailing space in the className after "text-gray-400". Consider removing it for consistency.

Suggested change
className={`${isSelected ? 'text-gray-900' : 'text-gray-400'} ${itemTextClassName} `}
className={`${isSelected ? 'text-gray-900' : 'text-gray-400'} ${itemTextClassName}`}

Copilot uses AI. Check for mistakes.
Comment on lines +104 to +105
<View className="p-4 ">
<View className="w-full max-w-xl gap-6 rounded-2xl bg-white p-5 ">
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a trailing space in the className. This should be removed for cleaner code.

Suggested change
<View className="p-4 ">
<View className="w-full max-w-xl gap-6 rounded-2xl bg-white p-5 ">
<View className="p-4">
<View className="w-full max-w-xl gap-6 rounded-2xl bg-white p-5">

Copilot uses AI. Check for mistakes.
<View className="flex-row items-start justify-between">
<View>
<Text className="font-serif text-xs tracking-[0.25em] text-gray-400">{year}</Text>
<Text className="font-serif text-xs tracking-[0.25em] text-gray-400 font-noto">
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using both font-serif and font-noto classes on the same element is redundant and confusing. Since both classes set the font-family property, only the last one in the CSS cascade will take effect. Consider using only the font-noto class (which applies the NotoSerifKR font) and removing font-serif, or verify which font family should actually be used.

Copilot uses AI. Check for mistakes.
) : fortune ? (
<Text className="text-center font-serif text-lg font-semibold leading-7 text-gray-600">
{fortune.overview}
<Text className="text-center font-serif text-lg font-semibold leading-7 text-gray-600 font-noto">
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using both font-serif and font-noto classes on the same element is redundant. Only one font-family declaration should be used. Consider removing font-serif since font-noto is the intended font.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat - UI 업데이트

2 participants