feat - 푸시알림 등록 #54

mark77234 · 2025-12-27T08:54:15Z

작업내용

푸시알림 등록작업

Copilot

Pull request overview

This PR implements Firebase Cloud Messaging (FCM) push notification support for the Android application, enabling the app to receive and display push notifications. The implementation includes FCM token management, notification channel setup for Android 8.0+, runtime permission handling for Android 13+, and integration with the sign-in flow to register device tokens with the backend.

Key Changes:

Added Firebase Messaging SDK dependencies and service configuration
Implemented FCM token storage and retrieval using DataStoreManager
Modified sign-in flow to include FCM token in authentication requests

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
app/build.gradle.kts	Added Firebase BOM and messaging dependencies with Google services plugin
app/src/main/AndroidManifest.xml	Added POST_NOTIFICATIONS permission and registered FCM service with metadata
app/src/main/res/values/strings.xml	Added string resources for default notification channel configuration
app/src/main/java/com/apptive/japkor/push/NotificationChannels.kt	Created utility function to ensure notification channel exists for Android O+
app/src/main/java/com/apptive/japkor/push/JapKorFirebaseMessagingService.kt	Implemented FCM service to handle token refresh and incoming messages
app/src/main/java/com/apptive/japkor/data/local/DataStoreManager.kt	Added FCM token storage and retrieval methods
app/src/main/java/com/apptive/japkor/data/model/Auth.kt	Extended SignInDTO to include fcmToken parameter
app/src/main/java/com/apptive/japkor/data/repository/AuthRepository.kt	Updated signIn method to pass FCM token to API
app/src/main/java/com/apptive/japkor/ui/login/LoginScreenViewModel.kt	Modified login flow to retrieve and send FCM token
app/src/main/java/com/apptive/japkor/MainActivity.kt	Added notification permission request and FCM token initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-27T08:57:30Z

app/src/main/java/com/apptive/japkor/push/JapKorFirebaseMessagingService.kt

+        NotificationManagerCompat.from(this)
+            .notify(System.currentTimeMillis().toInt(), notification)


Missing runtime permission check before displaying notifications. On Android 13 (API 33) and above, the POST_NOTIFICATIONS permission can be denied by users even after being requested. You should check if the permission is granted before calling notify(), otherwise a SecurityException could be thrown when the permission is denied.

Copilot · 2025-12-27T08:57:31Z

app/src/main/java/com/apptive/japkor/ui/login/LoginScreenViewModel.kt


            try {
-                val result = repository.signIn(email, password)
+                val fcmToken = dataStore.getFcmToken().first()


Potential null pointer exception when fcmToken is empty. If getFcmToken() returns an empty string (which happens when the token hasn't been saved yet), this empty string will be sent to the API. The login could fail during app's first launch before the FCM token is obtained. Consider handling this case by either waiting for the token to be available, deferring the login, or making the token optional in the sign-in flow.

Suggested change

val fcmToken = dataStore.getFcmToken().first()

val storedFcmToken = dataStore.getFcmToken().first()

val fcmToken = storedFcmToken.takeIf { it.isNotBlank() }

if (fcmToken == null) {

Log.w("LoginVM", "FCM token is not yet available; proceeding with sign-in without it.")

}

Copilot · 2025-12-27T08:57:31Z

app/src/main/java/com/apptive/japkor/MainActivity.kt

+        FirebaseMessaging.getInstance().token
+            .addOnCompleteListener { task ->
+                if (!task.isSuccessful) {
+                    Log.w(TAG, "Fetching FCM registration token failed", task.exception)
+                    return@addOnCompleteListener
+                }
+
+                val token = task.result
+                Log.d(TAG, "FCM token: $token")
+                lifecycleScope.launch {
+                    dataStoreManager.saveFcmToken(token)
+                }
+            }


Race condition between FCM token fetch and login. The FCM token is fetched asynchronously in MainActivity.onCreate() (lines 54-66) and saved via lifecycleScope.launch. However, if a user navigates to the login screen and attempts to sign in before this async operation completes, the fcmToken retrieved at line 45 could be empty. This creates a timing-dependent bug where login behavior differs based on how quickly the user navigates.

Copilot · 2025-12-27T08:57:31Z

app/src/main/java/com/apptive/japkor/data/model/Auth.kt

    val email: String,
-    val password: String
+    val password: String,
+    val fcmToken: String,


Missing trailing comma in data class parameter list. For consistency with Kotlin coding conventions and to reduce diff noise in future changes, add a trailing comma after the fcmToken parameter.

Copilot · 2025-12-27T08:57:31Z

app/src/main/java/com/apptive/japkor/data/model/Auth.kt

    val email: String,
-    val password: String
+    val password: String,
+    val fcmToken: String,


API design concern - mandatory FCM token may break existing clients. Adding fcmToken as a required parameter to SignInDTO makes it mandatory for all sign-in requests. If there are other clients or older app versions still using the API, this would break their login functionality. Consider making the fcmToken parameter optional (nullable) in the DTO to maintain backward compatibility.

Suggested change

val fcmToken: String,

val fcmToken: String? = null,

Copilot · 2025-12-27T08:57:32Z

app/src/main/java/com/apptive/japkor/data/repository/AuthRepository.kt


-    suspend fun signIn(email:String,password:String) : SignInResponse?{
-        val response = api.signIn(SignInDTO(email,password)).awaitResponse()
+    suspend fun signIn(email: String, password: String, fcmToken: String) : SignInResponse?{


Inconsistent parameter spacing in function signature. The function parameters have inconsistent spacing around colons. The email parameter has "email: String" with proper spacing, while the original code likely had different spacing. Ensure consistent formatting with spaces after colons for all parameters.

Copilot · 2025-12-27T08:57:32Z

app/src/main/java/com/apptive/japkor/push/JapKorFirebaseMessagingService.kt

+    override fun onNewToken(token: String) {
+        Log.d(TAG, "New FCM token: $token")
+        CoroutineScope(Dispatchers.IO).launch {
+            DataStoreManager(applicationContext).saveFcmToken(token)


Missing error handling for FCM token generation. If the FCM token retrieval fails in onNewToken(), the coroutine will crash silently without any fallback mechanism. Consider adding try-catch error handling and logging any failures, so that token save failures don't go unnoticed.

Suggested change

DataStoreManager(applicationContext).saveFcmToken(token)

try {

DataStoreManager(applicationContext).saveFcmToken(token)

} catch (e: Exception) {

Log.e(TAG, "Failed to save FCM token", e)

}

Copilot · 2025-12-27T08:57:32Z

app/src/main/java/com/apptive/japkor/push/NotificationChannels.kt

+import android.content.Context
+import android.os.Build
+import com.apptive.japkor.R
+


Missing documentation for public function. The ensureDefaultNotificationChannel function is a public API used across multiple files but lacks documentation explaining its purpose, when it should be called, and why it's safe to call multiple times. Consider adding KDoc to explain that this function is idempotent and handles channel creation for Android O and above.

Suggested change

/**

* Ensures that the app's default notification channel exists.

*

* This function should be called before posting notifications that rely on the

* default FCM notification channel (for example during app startup or when

* initializing push notification handling).

*

* On Android versions prior to O (API 26), this method is a no-op because

* notification channels are not supported. On Android O and above, it will

* create the default channel if it does not already exist.

*

* The operation is idempotent and safe to call multiple times: if the channel

* already exists, the existing channel is left unchanged.

*

* @param context a [Context] used to access resources and the [NotificationManager].

*/

Copilot · 2025-12-27T08:57:32Z

app/src/main/java/com/apptive/japkor/push/JapKorFirebaseMessagingService.kt

+            .build()
+
+        NotificationManagerCompat.from(this)
+            .notify(System.currentTimeMillis().toInt(), notification)


Potential notification ID collision and memory issue. Using System.currentTimeMillis().toInt() as the notification ID can lead to problems: (1) notifications arriving within the same millisecond will have the same ID and overwrite each other, (2) the cast to Int can cause collisions due to truncation. Consider using a more reliable approach such as a sequential counter or hash of the message ID.

* feat: fcm 토큰 발급 * feat: 로그인 필드에 fcmtoken 추가 * feat: FCM 알림 기능 추가 및 기본 채널 설정 * feat: MainScreen에서 알림 권한 요청 기능 추가

* feat: 로그인 api 연동(진짜최종) * feat - 푸시알림 등록 (#54) * feat: fcm 토큰 발급 * feat: 로그인 필드에 fcmtoken 추가 * feat: FCM 알림 기능 추가 및 기본 채널 설정 * feat: MainScreen에서 알림 권한 요청 기능 추가 * feat: 버전 업데이트 (1.0.1) * feat - 회원가입, 필수정보입력 필드 업데이트 (#57) * feat: 필수정보입력 실명 필드 추가 * feat: 회원가입 이름 필드 제거 * feat: 버전 업데이트 (1.0.2) * feat: ADID 추가 * feat: FCM 토큰 가져오기 및 저장 로직 추가 (#59) * feat: 구글로그인 응답로그 추가 * feat: 구글로그인 status 필드 대응 * fix: 구글로그인 버튼 위치 변경 --------- Co-authored-by: BYEONGCHAN LEE <mark77234@naver.com>

mark77234 added 3 commits December 27, 2025 17:16

feat: fcm 토큰 발급

4d05080

feat: 로그인 필드에 fcmtoken 추가

271e109

feat: FCM 알림 기능 추가 및 기본 채널 설정

639d732

Copilot AI review requested due to automatic review settings December 27, 2025 08:54

mark77234 linked an issue Dec 27, 2025 that may be closed by this pull request

[feat] firebase 연동 #52

Closed

3 tasks

Copilot started reviewing on behalf of mark77234 December 27, 2025 08:54 View session

Copilot AI reviewed Dec 27, 2025

View reviewed changes

feat: MainScreen에서 알림 권한 요청 기능 추가

715fdb8

mark77234 self-assigned this Dec 29, 2025

mark77234 merged commit 92e7684 into dev Dec 29, 2025
1 check failed

mark77234 deleted the feat/52 branch December 29, 2025 05:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat - 푸시알림 등록 #54

feat - 푸시알림 등록 #54

Uh oh!

mark77234 commented Dec 27, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Copilot AI Dec 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		NotificationManagerCompat.from(this)
		.notify(System.currentTimeMillis().toInt(), notification)

-                val fcmToken = dataStore.getFcmToken().first()
+                val storedFcmToken = dataStore.getFcmToken().first()
+                val fcmToken = storedFcmToken.takeIf { it.isNotBlank() }
+                if (fcmToken == null) {
+                    Log.w("LoginVM", "FCM token is not yet available; proceeding with sign-in without it.")
+                }

+/**
+ * Ensures that the app's default notification channel exists.
+ *
+ * This function should be called before posting notifications that rely on the
+ * default FCM notification channel (for example during app startup or when
+ * initializing push notification handling).
+ *
+ * On Android versions prior to O (API 26), this method is a no-op because
+ * notification channels are not supported. On Android O and above, it will
+ * create the default channel if it does not already exist.
+ *
+ * The operation is idempotent and safe to call multiple times: if the channel
+ * already exists, the existing channel is left unchanged.
+ *
+ * @param context a [Context] used to access resources and the [NotificationManager].
+ */

feat - 푸시알림 등록 #54

feat - 푸시알림 등록 #54

Uh oh!

Conversation

mark77234 commented Dec 27, 2025

작업내용

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants