feat - 회원가입, 필수정보입력 필드 업데이트 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the user registration flow by moving the name field from the initial sign-up screen to the required information input screen (Step 2), allowing users to complete their basic registration first and provide their name later during the detailed profile setup.
- Removed name field from sign-up process (SignUpDTO, SignUpViewModel, SignUpScreen)
- Added name field to required info input (RequiredInfoDTO, RequiredInfoViewModel, Step2Content)
- Updated validation logic to reflect the new field placement
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
app/src/main/java/com/apptive/japkor/data/model/Auth.kt |
Removed name field from SignUpDTO data model |
app/src/main/java/com/apptive/japkor/ui/signup/SignUpViewModel.kt |
Removed name parameter from signUp function |
app/src/main/java/com/apptive/japkor/ui/signup/SignUpScreen.kt |
Removed name input field UI, updated button validation, cleaned up unused import |
app/src/main/java/com/apptive/japkor/data/model/RequiredInfo.kt |
Added name field to RequiredInfoDTO data model |
app/src/main/java/com/apptive/japkor/ui/requiredinfo/RequiredInfoViewModel.kt |
Added name state field with validation logic in step2Valid and submitRequiredInfo |
app/src/main/java/com/apptive/japkor/ui/requiredinfo/steps/Step2Content.kt |
Added name input field to Step 2 UI, updated comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mark77234
added a commit
that referenced
this pull request
Dec 29, 2025
* feat: 필수정보입력 실명 필드 추가 * feat: 회원가입 이름 필드 제거
fkal829
added a commit
that referenced
this pull request
Jan 2, 2026
* feat: 로그인 api 연동(진짜최종) * feat - 푸시알림 등록 (#54) * feat: fcm 토큰 발급 * feat: 로그인 필드에 fcmtoken 추가 * feat: FCM 알림 기능 추가 및 기본 채널 설정 * feat: MainScreen에서 알림 권한 요청 기능 추가 * feat: 버전 업데이트 (1.0.1) * feat - 회원가입, 필수정보입력 필드 업데이트 (#57) * feat: 필수정보입력 실명 필드 추가 * feat: 회원가입 이름 필드 제거 * feat: 버전 업데이트 (1.0.2) * feat: ADID 추가 * feat: FCM 토큰 가져오기 및 저장 로직 추가 (#59) * feat: 구글로그인 응답로그 추가 * feat: 구글로그인 status 필드 대응 * fix: 구글로그인 버튼 위치 변경 --------- Co-authored-by: BYEONGCHAN LEE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 PR 개요
회원가입, 필수정보입력 필드 변경 반영했습니다
🔗 관련 이슈
#56
🧩 작업 상세