feat - ai 요약 기능 추가 #70

mark77234 · 2026-01-08T06:57:05Z

작업내용

ai 요약 api 연동 및 추가
필수정보입력 선호, 비선호 필드 직업 추가
매칭 조회 실패 시 토스트 제거

추후 업데이트 필요

로그인 시 성별 업데이트
ai 요약 섹션 UI 업데이트
ai 요약 성별에 따라 따로 처리

Copilot

Pull request overview

This PR adds AI summary functionality to display user profile summaries in Korean and Japanese, expands job options in the required info form, and implements gender-based control for matching selection. The changes include API integration, UI updates, and data persistence improvements.

Key changes:

AI summary API integration with bilingual (Korean/Japanese) display in the waiting screen
Expanded job options from 5 to 24 choices in the required info form
Gender storage in DataStore and gender-based matching selection controls
Removed toast notifications when matching queries fail

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
AiSummaryResponse.kt	New data model for AI summary API response with Korean and Japanese text fields
MatchingService.kt	Added AI summary endpoint and renamed matching selection method to gender-specific name
DataStoreManager.kt	Added gender storage and retrieval functionality
RequiredInfoMapper.kt	Expanded job mapping from 5 to 24 job types including healthcare, education, and public service roles
Step5Content.kt	Updated UI job options list to match expanded mapper entries
RequiredInfoViewModel.kt	Added gender persistence when submitting required info form
HomeViewModel.kt	Added AI summary fetching logic and refactored state updates to use update pattern
HomeScreen.kt	Added AI summary display in waiting screen with loading and error states
MainRouteScreen.kt	Added gender-based control flow for enabling/disabling matching selection
Localization.kt	Added Japanese translations for AI summary UI text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-08T07:03:08Z

app/src/main/java/com/apptive/japkor/ui/main/home/HomeViewModel.kt

+                        _uiState.update {
+                            it.copy(
+                                isLoading = false,
+                                matchings = emptyList(),
+                                selectedMatching = null,
+                                isWaiting = true
+                            )
+                        }
                    } else {
-                        _uiState.value = HomeUiState(matchings = data)
+                        _uiState.update {
+                            it.copy(
+                                isLoading = false,
+                                matchings = data,
+                                selectedMatching = null,
+                                isWaiting = false
+                            )
+                        }


The state updates in fetchFemaleMatchings don't preserve the AI summary fields (aiSummaryKo, aiSummaryJa, isAiSummaryLoading, aiSummaryError). When matchings data is updated, these fields will be reset to their default null/false values because the copy operation only specifies isLoading, matchings, selectedMatching, and isWaiting. This will cause the AI summary to disappear if matchings are refreshed after the AI summary has loaded.

Copilot · 2026-01-08T07:03:09Z

app/src/main/java/com/apptive/japkor/ui/main/home/HomeViewModel.kt

+                    _uiState.update {
+                        it.copy(
+                            isLoading = false,
+                            matchings = emptyList(),
+                            selectedMatching = null,
+                            isWaiting = true
+                        )
+                    }


The state updates don't preserve the AI summary fields (aiSummaryKo, aiSummaryJa, isAiSummaryLoading, aiSummaryError). When matchings fail to load, these fields will be reset to their default values, causing the AI summary to disappear.

Copilot · 2026-01-08T07:03:09Z

app/src/main/java/com/apptive/japkor/ui/main/home/HomeViewModel.kt

+                            isLoading = false,
+                            matchings = emptyList(),
+                            selectedMatching = null,
+                            isWaiting = true


The state updates don't preserve the AI summary fields (aiSummaryKo, aiSummaryJa, isAiSummaryLoading, aiSummaryError). When a matching is selected, these fields will be reset to their default values, causing the AI summary to disappear from the waiting screen if the user returns to it.

Suggested change

isWaiting = true

isWaiting = true,

aiSummaryKo = it.aiSummaryKo,

aiSummaryJa = it.aiSummaryJa,

isAiSummaryLoading = it.isAiSummaryLoading,

aiSummaryError = it.aiSummaryError

Copilot · 2026-01-08T07:03:10Z

app/src/main/java/com/apptive/japkor/data/api/MatchingService.kt

-
-    @GET("members/status")
-    suspend fun getMyStatus(): MyStatusResponse
+    fun femaleSelectMatching(@Path("matchingId") matchingId: Long): Call<Void>


Function name 'femaleSelectMatching' uses gender-specific naming which may not scale well if male users need similar functionality in the future. Consider a more generic name like 'selectMatching' or 'confirmMatching' that doesn't encode gender into the API method name.

Suggested change

fun femaleSelectMatching(@Path("matchingId") matchingId: Long): Call<Void>

fun selectMatching(@Path("matchingId") matchingId: Long): Call<Void>

Copilot · 2026-01-08T07:03:10Z

app/src/main/java/com/apptive/japkor/utils/required_info/RequiredInfoMapper.kt

    fun job(koreanLabel: String): String? = when (koreanLabel) {
        "의사" -> "DOCTOR"
+        "약사" -> "PHARMACIST"
+        "간호사" -> "NURSE"
        "교사" -> "TEACHER"
+        "교수" -> "PROFESSOR"
+        "변호사" -> "LAWYER"
+        "회계사" -> "ACCOUNTANT"
        "엔지니어" -> "ENGINEER"
+        "개발자" -> "DEVELOPER"
+        "디자이너" -> "DESIGNER"
+        "공무원" -> "CIVIL_SERVANT"
+        "경찰" -> "POLICE"
+        "소방관" -> "FIREFIGHTER"
+        "군인" -> "MILITARY"
+        "사업가" -> "ENTREPRENEUR"
+        "경영인" -> "CEO"
+        "금융인" -> "FINANCE"
+        "연구원" -> "RESEARCHER"
+        "예술가" -> "ARTIST"
+        "운동선수" -> "ATHLETE"
        "프리랜서" -> "FREELANCER"
+        "학생" -> "STUDENT"
        "무직" -> "UNEMPLOYED"
+        "상관없음" -> "ANY"
+        "상관 없음" -> "ANY"
+        "기타" -> "OTHER"
        else -> null


The mapping for "상관없음" and "상관 없음" (with different spacing) both map to "ANY". This duplication could be avoided by normalizing whitespace in the input string before checking, which would make the mapping more maintainable and handle other potential spacing variations.

Suggested change

fun job(koreanLabel: String): String? = when (koreanLabel) {

"의사" -> "DOCTOR"

"약사" -> "PHARMACIST"

"간호사" -> "NURSE"

"교사" -> "TEACHER"

"교수" -> "PROFESSOR"

"변호사" -> "LAWYER"

"회계사" -> "ACCOUNTANT"

"엔지니어" -> "ENGINEER"

"개발자" -> "DEVELOPER"

"디자이너" -> "DESIGNER"

"공무원" -> "CIVIL_SERVANT"

"경찰" -> "POLICE"

"소방관" -> "FIREFIGHTER"

"군인" -> "MILITARY"

"사업가" -> "ENTREPRENEUR"

"경영인" -> "CEO"

"금융인" -> "FINANCE"

"연구원" -> "RESEARCHER"

"예술가" -> "ARTIST"

"운동선수" -> "ATHLETE"

"프리랜서" -> "FREELANCER"

"학생" -> "STUDENT"

"무직" -> "UNEMPLOYED"

"상관없음" -> "ANY"

"상관 없음" -> "ANY"

"기타" -> "OTHER"

else -> null

fun job(koreanLabel: String): String? {

val normalized = koreanLabel.replace("\\s+".toRegex(), "")

return when (normalized) {

"의사" -> "DOCTOR"

"약사" -> "PHARMACIST"

"간호사" -> "NURSE"

"교사" -> "TEACHER"

"교수" -> "PROFESSOR"

"변호사" -> "LAWYER"

"회계사" -> "ACCOUNTANT"

"엔지니어" -> "ENGINEER"

"개발자" -> "DEVELOPER"

"디자이너" -> "DESIGNER"

"공무원" -> "CIVIL_SERVANT"

"경찰" -> "POLICE"

"소방관" -> "FIREFIGHTER"

"군인" -> "MILITARY"

"사업가" -> "ENTREPRENEUR"

"경영인" -> "CEO"

"금융인" -> "FINANCE"

"연구원" -> "RESEARCHER"

"예술가" -> "ARTIST"

"운동선수" -> "ATHLETE"

"프리랜서" -> "FREELANCER"

"학생" -> "STUDENT"

"무직" -> "UNEMPLOYED"

"상관없음" -> "ANY"

"기타" -> "OTHER"

else -> null

}

Copilot · 2026-01-08T07:03:11Z

app/src/main/java/com/apptive/japkor/ui/main/home/HomeScreen.kt

+                        if (canSelectMatching) {
+                            onConfirm(selectedMatching.matchingId)
+                        }


The canSelectMatching check is redundant here. The button is already disabled when canSelectMatching is false (via the 'enabled' parameter on line 369), so this conditional check will never prevent the action from executing - disabled buttons don't trigger onClick. This extra check adds unnecessary complexity.

Suggested change

if (canSelectMatching) {

onConfirm(selectedMatching.matchingId)

}

onConfirm(selectedMatching.matchingId)

Copilot · 2026-01-08T07:03:12Z

app/src/main/java/com/apptive/japkor/ui/main/home/HomeViewModel.kt

+                            aiSummaryKo = null,
+                            aiSummaryJa = null,
+                            isAiSummaryLoading = false,
+                            aiSummaryError = "AI 요약본을 불러오지 못했습니다."


Error message is hardcoded in Korean and won't be localized for Japanese users. The error message should use the AppLocalizer system like other UI text, especially since this is displayed in the WaitingContent which is visible to all users.

Copilot · 2026-01-08T07:03:12Z

app/src/main/java/com/apptive/japkor/ui/main/home/HomeViewModel.kt

+                        aiSummaryKo = null,
+                        aiSummaryJa = null,
+                        isAiSummaryLoading = false,
+                        aiSummaryError = "AI 요약본을 불러오지 못했습니다."


Error message is hardcoded in Korean and won't be localized for Japanese users. The error message should use the AppLocalizer system like other UI text, especially since this is displayed in the WaitingContent which is visible to all users.

Copilot · 2026-01-08T07:03:12Z

app/src/main/java/com/apptive/japkor/data/model/AiSummaryResponse.kt

+    val memberId: Long,
+    @SerializedName(value = "name")
+    val name: String,
+    @SerializedName(value = "aiSummaryKo", alternate = ["ai_summary_ko", "aiSummary", "ai_summary"])


The SerializedName annotation includes multiple alternate field names for aiSummaryKo (including "aiSummary" and "ai_summary"), which suggests uncertainty about the API contract. This can lead to maintenance issues if the API changes or if different endpoints return different field names. Consider clarifying the API specification to use a consistent field name.

Suggested change

@SerializedName(value = "aiSummaryKo", alternate = ["ai_summary_ko", "aiSummary", "ai_summary"])

@SerializedName(value = "aiSummaryKo", alternate = ["ai_summary_ko"])

Copilot · 2026-01-08T07:03:12Z

app/src/main/java/com/apptive/japkor/ui/main/home/HomeScreen.kt

+                            text = "한국어",
+                            type = CustomTextType.label,
+                            color = CustomColor.gray400
+                        )


The text "한국어" used as a label for the Korean language summary section lacks a localization entry. When the app is in Japanese mode, this label should display "韓国語" (Korean language), but will remain as "한국어" instead. Add a localization mapping for this context.

mark77234 added 5 commits January 6, 2026 20:29

feat: 사용자 성별 저장 및 선택 가능 여부 추가

b8fbe05

feat: ai 요약 api 연동

1bf58c0

feat: 선호, 비선호 직업 추가

b264f7e

feat: 내 ai요약정보 api 연동

2e9673d

fix: 매칭 조회 실패 토스트 제거

48ed807

Copilot AI review requested due to automatic review settings January 8, 2026 06:57

mark77234 linked an issue Jan 8, 2026 that may be closed by this pull request

[feat] 홈 매칭중 화면 #68

Closed

1 task

Merge branch 'dev' into feat/68

b166546

Copilot started reviewing on behalf of mark77234 January 8, 2026 06:57 View session

mark77234 added the feat 기능 추가 작업 label Jan 8, 2026

mark77234 self-assigned this Jan 8, 2026

mark77234 merged commit 611f5b5 into dev Jan 8, 2026
1 check failed

mark77234 deleted the feat/68 branch January 8, 2026 06:57

Copilot AI reviewed Jan 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat - ai 요약 기능 추가 #70

feat - ai 요약 기능 추가 #70

Uh oh!

mark77234 commented Jan 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-                            isWaiting = true
+                            isWaiting = true,
+                            aiSummaryKo = it.aiSummaryKo,
+                            aiSummaryJa = it.aiSummaryJa,
+                            isAiSummaryLoading = it.isAiSummaryLoading,
+                            aiSummaryError = it.aiSummaryError

	fun femaleSelectMatching(@Path("matchingId") matchingId: Long): Call<Void>
	fun selectMatching(@Path("matchingId") matchingId: Long): Call<Void>

	@SerializedName(value = "aiSummaryKo", alternate = ["ai_summary_ko", "aiSummary", "ai_summary"])
	@SerializedName(value = "aiSummaryKo", alternate = ["ai_summary_ko"])

feat - ai 요약 기능 추가 #70

feat - ai 요약 기능 추가 #70

Uh oh!

Conversation

mark77234 commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

작업내용

추후 업데이트 필요

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mark77234 commented Jan 8, 2026 •

edited

Loading