feat - 매칭 대기화면 UI 업데이트 #86
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the matching waiting screen UI by refactoring the home screen components into separate, reusable composables and adding enhanced visual elements including AI summary cards and carousel-based matching displays.
Changes:
- Fixed religion mapping typo in RequiredInfoMapper (TOISM → SHINTO)
- Refactored HomeScreen by extracting three major UI components into separate files for better maintainability
- Enhanced data models with image URL support and moved HomeMatching to the data layer
- Updated API endpoints to include more specific paths for male/female matching operations
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| RequiredInfoMapper.kt | Fixed typo in Shinto religion mapping constant |
| WaitingContent.kt | New component displaying waiting state with AI summary in stacked card design |
| MatchingDetailContent.kt | New component showing detailed matching profile information with images |
| MatchingCarouselContent.kt | New component providing carousel-based matching card navigation |
| HomeViewModel.kt | Added userName field and image URL mappings to matching data |
| HomeScreen.kt | Refactored to use extracted components, removed inline implementations |
| HomeMatching.kt | Removed (moved to data model layer) |
| Matching.kt | Added HomeMatching data class with image URL fields |
| UserService.kt | Updated getUserInfo endpoint path |
| MatchingService.kt | Updated matching endpoint paths to be more specific (male/female prefixes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| DetailImageItem(label = "thumbnailImageUrl", imageUrl = matching.thumbnailImageUrl) | ||
| DetailImageItem(label = "profileImageUrl", imageUrl = matching.profileImageUrl) |
There was a problem hiding this comment.
The labels "thumbnailImageUrl" and "profileImageUrl" appear to be internal variable names rather than user-facing labels. These should be replaced with localized, user-friendly Korean labels like "썸네일 이미지" and "프로필 이미지" to match the pattern used for other fields like "이름", "이메일", "키", etc.
| DetailImageItem(label = "thumbnailImageUrl", imageUrl = matching.thumbnailImageUrl) | |
| DetailImageItem(label = "profileImageUrl", imageUrl = matching.profileImageUrl) | |
| DetailImageItem(label = "썸네일 이미지", imageUrl = matching.thumbnailImageUrl) | |
| DetailImageItem(label = "프로필 이미지", imageUrl = matching.profileImageUrl) |
| color = CustomColor.gray400, | ||
| textAlign = TextAlign.Center, | ||
| modifier = Modifier.padding(horizontal = 24.dp), | ||
| size= 18.sp |
There was a problem hiding this comment.
Missing space after 'size=' parameter. Should be 'size = 18.sp' for consistent code formatting with Kotlin conventions.
| size= 18.sp | |
| size = 18.sp |
| color = CustomColor.gray300, | ||
| textAlign = TextAlign.Center, | ||
| modifier = Modifier.padding(horizontal = 42.dp), | ||
| size= 16.sp |
There was a problem hiding this comment.
Missing space after 'size=' parameter. Should be 'size = 16.sp' for consistent code formatting with Kotlin conventions.
| size= 16.sp | |
| size = 16.sp |
| type = CustomTextType.mainRegular, | ||
| color = CustomColor.gray400, | ||
| textAlign = TextAlign.Start, | ||
| size=20.sp |
There was a problem hiding this comment.
Missing space after 'size=' parameter. Should be 'size = 20.sp' for consistent code formatting with Kotlin conventions.
| size=20.sp | |
| size = 20.sp |
| modifier: Modifier = Modifier | ||
| ) { | ||
| Column( | ||
| modifier = Modifier |
There was a problem hiding this comment.
The MatchingCard composable is missing the 'modifier' parameter usage. The modifier parameter is declared but never applied to the root Column element, which means any modifiers passed to this composable will be ignored. Apply the modifier to the Column by changing line 162 to: 'modifier = modifier'.
| modifier = Modifier | |
| modifier = modifier |
작업내용
추후 업데이트 사항