Open
Conversation
Moves <SharedLayout /> and everything that depends on it to the @app/client tree. Rationale: <SharedLayout /> needs to read process.env.T_AND_C_URL, which is a detail of the build that @app/components shouldn't know about. When environment variable injection changes with Turbopack, we'll want to limit the blast radius. The other option was passing termsAndConditionsUrl as a prop from @app/client into <SharedLayout /> everywhere we render it. But these layout components aren't logically reusable outside of their new locations in pages/ anyway, so it makes more sense to relocate them. unblocks turbopack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
<SharedLayout />and everything that depends on it to the@app/clienttree. Rationale:<SharedLayout />needs to readprocess.env.T_AND_C_URL, which is a detail of the build that@app/componentsshouldn't know about.When environment variable injection changes with Turbopack, we'll want to limit the blast radius.
The other option was passing
termsAndConditionsUrlas a prop from@app/clientinto<SharedLayout />everywhere we render it. But these layout components aren't logically reusable outside of their new locations in pages/ anyway, so it makes more sense to relocate them.unblocks turbopack