Remove redundant cluster size check #423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since fit_quad checks that the cluster size is above 24, the min_cluster_pixels comparision is essentially useless for values below 24. Invert it so that min_cluster_pixels is now 24, and remove the now redundant hardcoded 24 check. Move the size variable down as well for better locality of behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fit_quad checks that the cluster size is above 24, the min_cluster_pixels comparision is essentially useless for values below 24. Invert it so that min_cluster_pixels is now 24, and remove the now redundant hardcoded 24 check. Move the size variable down as well for better locality of behavior.