Skip to content

Meatballs util: Refactor; remove duplicate code#1712

Merged
marcustyphoon merged 5 commits intoAprilSylph:masterfrom
marcustyphoon:meatballs-deduplicate-refactor
Feb 16, 2025
Merged

Meatballs util: Refactor; remove duplicate code#1712
marcustyphoon merged 5 commits intoAprilSylph:masterfrom
marcustyphoon:meatballs-deduplicate-refactor

Conversation

@marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Jan 27, 2025

Description

This cleans up a big chunk of copy-pasted code that was added to the meatballs util in #910, making the addition of meatball menu items generic over different types (post, blog). This makes it easier to add additional types of meatball menu to target (#1662).

Testing steps

  • Confirm that PostBlock/Mirror Posts meatball items work correctly.
  • Confirm that NotificationBlock meatball items only appear on user posts and work correctly.
  • Merge New Feature: Mute #677 into this PR and confirm that blog meatball items work correctly.

@marcustyphoon marcustyphoon self-assigned this Jan 27, 2025
that's not how that works huh
@marcustyphoon marcustyphoon merged commit 169986a into AprilSylph:master Feb 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants