-
-
Notifications
You must be signed in to change notification settings - Fork 51
feat(Scroll to Bottom): Add preference to stop at Changes carousel #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcustyphoon
wants to merge
25
commits into
AprilSylph:master
Choose a base branch
from
marcustyphoon:scroll-to-bottom-caught-up
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
b099746
add stop at caught up preference
marcustyphoon a9066e3
scroll to carousel itself
marcustyphoon 46bf6e5
test code
marcustyphoon 2929c79
Revert "test code"
marcustyphoon b8bb1ea
no really this time we are waiting long enough.
marcustyphoon e187d6f
test code
marcustyphoon ad58dd0
Revert "test code"
marcustyphoon 7e85a18
Merge remote-tracking branch 'upstream/master' into scroll-to-bottom-…
marcustyphoon a4c0062
new method: check every cell
marcustyphoon bc1993a
fixes
marcustyphoon ca2b3b2
initial click behavior
marcustyphoon 32ac953
less arcane reliable scroll
marcustyphoon 0703ed8
extract debounce util
marcustyphoon cda6c45
remove test logging
marcustyphoon edd4aaf
variable name tweak
marcustyphoon 54e5040
Merge branch 'master' into scroll-to-bottom-caught-up
marcustyphoon 0cffebb
Merge remote-tracking branch 'upstream/master' into scroll-to-bottom-…
marcustyphoon bca8f01
Merge remote-tracking branch 'upstream/master' into scroll-to-bottom-…
marcustyphoon d47ec62
Merge branch 'master-without-commas' into scroll-to-bottom-caught-up
marcustyphoon 939fbfc
Merge remote-tracking branch 'upstream/master' into scroll-to-bottom-…
marcustyphoon 5f41c76
format
marcustyphoon e88991d
Merge remote-tracking branch 'upstream/master' into scroll-to-bottom-…
marcustyphoon 4f318b1
update new util function
marcustyphoon 3fd457a
fix jsdoc
marcustyphoon 0d37995
Merge remote-tracking branch 'upstream/master' into scroll-to-bottom-…
marcustyphoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| export default function unburyCellItem () { | ||
| const cellElement = this; | ||
| const reactKey = Object.keys(cellElement).find(key => key.startsWith('__reactFiber')); | ||
| let fiber = cellElement[reactKey]; | ||
|
|
||
| while (fiber !== null) { | ||
| const { item } = fiber.memoizedProps || {}; | ||
| if (item !== undefined) { | ||
| return item; | ||
| } else { | ||
| fiber = fiber.return; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export const debounce = (func, ms) => { | ||
| let timeoutID; | ||
| return (...args) => { | ||
| clearTimeout(timeoutID); | ||
| timeoutID = setTimeout(() => func(...args), ms); | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you ever look at a piece of code and go, "okay, that very obviously needs to be refactored to be simpler and shorter" but then see no way to actually do that?