chore: Enable deprecated timestamps feature on classic footer#1910
Open
marcustyphoon wants to merge 5 commits intoAprilSylph:masterfrom
Open
chore: Enable deprecated timestamps feature on classic footer#1910marcustyphoon wants to merge 5 commits intoAprilSylph:masterfrom
marcustyphoon wants to merge 5 commits intoAprilSylph:masterfrom
Conversation
marcustyphoon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feel free to not review this, obviously, but for sake of... completeness? Here is, you know, see the PR title.
This is a bit messier than the way I originally designed it, where Classic Footer had an additional element to serve as the gap between the note count and bottom right control buttons rather than using right margin on the note count, permitting additional insertion into the footer to simply be css order. I get why—you could easily mix terms in a way that would make no sense if there were—but it is always a little odd to me that there are not flexbox justify-self keywords.
Testing steps