chore: update xkit-controls-row styles#1911
Open
marcustyphoon wants to merge 7 commits intoAprilSylph:masterfrom
Open
chore: update xkit-controls-row styles#1911marcustyphoon wants to merge 7 commits intoAprilSylph:masterfrom
marcustyphoon wants to merge 7 commits intoAprilSylph:masterfrom
Conversation
This reverts commit 4f15b6f.
e5d7e5e to
3682449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #1904, we made some changes to the
xkit-controls-rowelement that our control button creates so that we can insert control buttons into editable posts without edit/delete buttons, i.e. those with the new footer. Tumblr then added back the edit/delete buttons in a newpostOwnerControlselement just when we thought we were done, making thexkit-controls-rowelement currently completely unused. We left it in as a fallback but didn't touch it further.This updates it to match the current
postOwnerControlselement, both with and without Classic Footer enabled, so that if it does ever get used as a fallback (or if we want to add control buttons to a non-editable post), its appearance will be consistent.Its position in the DOM, spacing, and bottom border line should be correct. Notably, this includes making the line span from post edge to post edge in non-classic-footer mode, which I personally think looks bad. But that's how Tumblr's element looks!
Tumblr's element was just changed today, illustrating that it's more likely to be changed again during this general timeframe, so in a sense this doesn't make much sense to merge now. Also, you know... at all, one could make the argument.
Testing steps
xkit-controls-rowon non-editable posts.