feat(Classic Footer): Move reblog modal to the left instead of the right#1912
Draft
marcustyphoon wants to merge 8 commits intoAprilSylph:masterfrom
Draft
feat(Classic Footer): Move reblog modal to the left instead of the right#1912marcustyphoon wants to merge 8 commits intoAprilSylph:masterfrom
marcustyphoon wants to merge 8 commits intoAprilSylph:masterfrom
Conversation
AprilSylph
reviewed
Nov 25, 2025
Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tumblr places the reblog button modal beneath and to the right of the reblog button (automatically changing if this would hit the screen edge). This makes sense, as the reblog button is on the left side of the post centerline. Classic Footer, however, puts the reblog button on the right side of the post centerline, so this should be reversed so that the modal isn't hanging off the right edge of the post.
This does so by carefully targeting a div element containing the modal and reversing its direction. Unfortunately, there aren't a lot of super specific, semantically relevant class names/attributes in this area, so it's, you know... not the best selector in the world.
Resolves #1924.
Testing steps