Skip to content

feat(Classic Footer): Move reblog modal to the left instead of the right#1912

Draft
marcustyphoon wants to merge 8 commits intoAprilSylph:masterfrom
marcustyphoon:classic-footer-move-reblog-modal
Draft

feat(Classic Footer): Move reblog modal to the left instead of the right#1912
marcustyphoon wants to merge 8 commits intoAprilSylph:masterfrom
marcustyphoon:classic-footer-move-reblog-modal

Conversation

@marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Oct 10, 2025

Description

Tumblr places the reblog button modal beneath and to the right of the reblog button (automatically changing if this would hit the screen edge). This makes sense, as the reblog button is on the left side of the post centerline. Classic Footer, however, puts the reblog button on the right side of the post centerline, so this should be reversed so that the modal isn't hanging off the right edge of the post.

This does so by carefully targeting a div element containing the modal and reversing its direction. Unfortunately, there aren't a lot of super specific, semantically relevant class names/attributes in this area, so it's, you know... not the best selector in the world.

Resolves #1924.

Testing steps

  • Click a reblog button. Note that the reblog modal appears mostly to the right of the reblog button.
  • Enable Classic Footer. (If you have the modal open, it won't move immediately, though it should if you resize the browser viewport or dismiss and reopen it.)
  • Click a reblog button. Confirm that the reblog modal appears mostly to the left of the reblog button. Open the blog selector dropdown and confirm that its appearance and function are reasonable.
  • Click a reblog button on a post with reblogs disabled. Confirm that the reblog modal appears mostly to the left of the reblog button. Open the blog selector dropdown and confirm that its appearance and function are reasonable.

@marcustyphoon marcustyphoon self-assigned this Nov 25, 2025
@marcustyphoon marcustyphoon removed their assignment Feb 9, 2026
@marcustyphoon marcustyphoon requested review from AprilSylph and removed request for AprilSylph February 9, 2026 23:46
@marcustyphoon marcustyphoon marked this pull request as draft February 10, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Classic Footer: Improve reblog menu positioning

2 participants