Skip to content

feat(Quote Replies): Add action buttons to replies in post notes (visible)#2112

Open
marcustyphoon wants to merge 43 commits intoAprilSylph:masterfrom
marcustyphoon:quote-replies-post-notes-button
Open

feat(Quote Replies): Add action buttons to replies in post notes (visible)#2112
marcustyphoon wants to merge 43 commits intoAprilSylph:masterfrom
marcustyphoon:quote-replies-post-notes-button

Conversation

@marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Feb 16, 2026

Description

Adapted from #1662.

This implements a button at the bottom of certain replies in the post footer, allowing the user to activate Quote Replies directly from that location if they would have been able to from the relevant item in the activity notifications menu/page.

Note that the situations referenced by the three types of verbiage ("replied to your post", "replied to you in a post" and "mentioned you on a post") used in Quote Replies have overlap. It's common for a threaded reply to one of your comments on one of your posts to be all three of these! When using Quote Replies from the activity notifications page/popup, the verbiage used is of course the one from the notification tab you're on (the same notification will appear in multiple tabs). In the notes in a post footer, any of them could accurately be said to apply.

This PR (see determineNoteReplyType) prioritizes them in the order "replied to you in a post" > "replied to your post" > "mentioned you on a post", which... I think makes sense? Most specific to most general.

Hm—I guess we could add a "replied to you on your post" verbiage if we wanted to.

(aside: my understanding is that at some point, some of what we're talking about here may become officially referred to as "comments," not "replies." I have no idea what the story is on that so for now I'll keep saying "replies" I guess)

Testing steps

Confirm that "quote this reply" buttons are added to replies in the post notes, and function when clicked, in these cases:

  • A user adds a root-level reply to your post. (Verbiage: "replied to your post")
  • A user adds a threaded reply to someone else's/their own reply, on your post. (Verbiage: "replied to your post")
  • A user adds a threaded reply to your reply, on your post. (Verbiage: "replied to you in a post"; see above)
  • A user adds a threaded reply to your reply, on someone else's/their own post. (Verbiage: "replied to you in a post")
  • A user mentions you in a root-level reply to someone else's/their own post. (Verbiage: "mentioned you on a post")
  • A user mentions you in a threaded reply to someone else's/their own reply, on someone else's/their own post. (Verbiage: "mentioned you on a post")

Check that the correct mentioned/replied-to blog is where the post draft is created.

also:

  • Confirm that "quote this reply" buttons are added to replies both in the "Viewing an individual reply thread. See all replies" permalink view linked from activity, and from the normal view of that post with all replies visible.
  • Confirm that "quote this reply" buttons are added to replies outside of the blog view (e.g. on the dash)

edit:

  • Use the "quote this reply" button on a reply in the post notes when viewing a post that is not a reblog. Confirm that the hyperlink on the post summary on a produced post draft points to the correct root post.
  • Use the "quote this reply" button on a reply in the post notes when viewing a post that is a reblog. Note that the hyperlink on the post summary on a produced post draft points to the reblog you were viewing. (The summary text is, I assume, generally the same on a reblog as on its root post? Right?)

is this really better though
This reverts commit 5d48cad.
This reverts commit 9ec059e.
@marcustyphoon

This comment was marked as resolved.

@marcustyphoon
Copy link
Collaborator Author

marcustyphoon commented Feb 16, 2026

Thoughts for @AprilSylph consideration:

  • Is this definitely better than putting something in the meatballs menu?
  • What is unambiguous terminology to distinguish between activity notifications and post notes? I was doing a second pass on renaming functions for clarity and realized all of a sudden that I was carefully using "activity" to mean activity notifications, but the post notes area literally has the aria label "Post Activity," so officially that clears up precisely nothing.
  • It winds up being more trouble than it's worth here, but: general thoughts on splitting a feature into multiple js files within its folder?
  • Ideas for an updated feature description?
  • Should these buttons be blue or match their companions?
  • If one clicks the Quote Replies button while viewing a reblog, should the summary link in the resulting quoted post be to that reblog, or the root post?

@marcustyphoon marcustyphoon marked this pull request as ready for review March 2, 2026 02:25
};

const determineNoteReplyType = ({ noteProps, parentNoteProps }) => {
if (userBlogNames.includes(noteProps.note.blogName)) return false;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting note from testing: this line excludes quote replying yourself, which probably makes sense in general... but a) maybe it doesn't (something something group blogs), and b) that's inconsistent with the behavior on activity items, which totally does let you quote reply yourself!

(comment copied from previous PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant