refactor: Create withModalOnError helper function#2129
Merged
marcustyphoon merged 5 commits intomasterfrom Mar 12, 2026
Merged
Conversation
conflicts with #1639
AprilSylph
approved these changes
Mar 12, 2026
This reverts commit 498573a.
marcustyphoon
changed the title
withErrorModal helper functionwithModalOnError helper function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This creates a
withErrorModalhelper function that wraps a given function inshowErrorModalto catch errors when it's executed. I find this more clear than writing e.g.event => onButtonClicked(event).catch(showErrorModal). My guess is that this is probably uncontroversial?Question is, would we want to write
withErrorModal(someCallback)in the place where it's used, as I did here, or around someCallback where it's defined? The latter breaks jsdoc.(cherry-picked from #2126)
Testing steps
Confirm that Mass Privater, Tag Replacer, and Trim Reblogs show error messages when attempting to use them with no network connection.