Skip to content

Commit 815fd8c

Browse files
authored
Merge pull request ceph#52068 from YiteGu/fix-trackedop-perfcounter
common/TrackedOp: rename and raise prio of slow op perfcounter Reviewed-by: Samuel Just <[email protected]>
2 parents 3d8a8fb + e1a0284 commit 815fd8c

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

src/common/TrackedOp.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ void OpHistory::_insert_delayed(const utime_t& now, TrackedOpRef op)
9090
arrived.insert(make_pair(op->get_initiated(), op));
9191
if (opduration >= history_slow_op_threshold.load()) {
9292
slow_op.insert(make_pair(op->get_initiated(), op));
93-
logger->inc(l_osd_slow_op_count);
93+
logger->inc(l_trackedop_slow_op_count);
9494
}
9595
cleanup(now);
9696
}

src/common/TrackedOp.h

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ class OpHistoryServiceThread : public Thread
5353
};
5454

5555
enum {
56-
l_osd_slow_op_first = 1000,
57-
l_osd_slow_op_count,
58-
l_osd_slow_op_last,
56+
l_trackedop_slow_op_first = 1000,
57+
l_trackedop_slow_op_count,
58+
l_trackedop_slow_op_last,
5959
};
6060

6161
class OpHistory {
@@ -76,9 +76,11 @@ class OpHistory {
7676

7777
public:
7878
OpHistory(CephContext *c) : cct(c), opsvc(this) {
79-
PerfCountersBuilder b(cct, "osd-slow-ops",
80-
l_osd_slow_op_first, l_osd_slow_op_last);
81-
b.add_u64_counter(l_osd_slow_op_count, "slow_ops_count",
79+
PerfCountersBuilder b(cct, "trackedop",
80+
l_trackedop_slow_op_first, l_trackedop_slow_op_last);
81+
b.set_prio_default(PerfCountersBuilder::PRIO_USEFUL);
82+
83+
b.add_u64_counter(l_trackedop_slow_op_count, "slow_ops_count",
8284
"Number of operations taking over ten second");
8385

8486
logger.reset(b.create_perf_counters());

0 commit comments

Comments
 (0)