Merge pull request ceph#63399 from Shwetha-Acharya/share_config_update

adk3798 · web-flow · commit a99f00584958 · 2025-06-17T11:52:27.000-04:00
mgr/smb: Add new configs to share definition

Reviewed-by: Adam King &lt;adking@redhat.com&gt;
Reviewed-by: John Mulligan &lt;jmulligan@redhat.com&gt;
diff --git a/qa/suites/orch/cephadm/smb/tasks/deploy_smb_basic.yaml b/qa/suites/orch/cephadm/smb/tasks/deploy_smb_basic.yaml
@@ -51,6 +51,8 @@ tasks:
             "kernel share modes" = "no"
             "read only" = "no"
             "browseable" = "yes"
+            "comment" = ""
+            "max connections" = "0"
             [globals.default.options]
             "load printers" = "no"
             "printing" = "bsd"
diff --git a/qa/suites/orch/cephadm/smb/tasks/deploy_smb_domain.yaml b/qa/suites/orch/cephadm/smb/tasks/deploy_smb_domain.yaml
@@ -50,6 +50,8 @@ tasks:
           "kernel share modes" = "no"
           "read only" = "no"
           "browseable" = "yes"
+          "comment" = ""
+          "max connections" = "0"
           [globals.default.options]
           "load printers" = "no"
           "printing" = "bsd"
diff --git a/src/pybind/mgr/smb/handler.py b/src/pybind/mgr/smb/handler.py
@@ -1196,6 +1196,8 @@ def _generate_share(
             'browseable': ynbool(share.browseable),
             'kernel share modes': 'no',
             'x:ceph:id': f'{share.cluster_id}.{share.share_id}',
+            'comment': '',
+            'max connections': '0',
         }
     }
     if proxy_val:

Original file line number	Diff line number	Diff line change
`@@ -1196,6 +1196,8 @@ def _generate_share(`
`1196`	`1196`	`'browseable': ynbool(share.browseable),`
`1197`	`1197`	`'kernel share modes': 'no',`
`1198`	`1198`	`'x:ceph:id': f'{share.cluster_id}.{share.share_id}',`
	`1199`	`+ 'comment': '',`
	`1200`	`+ 'max connections': '0',`
`1199`	`1201`	`}`
`1200`	`1202`	`}`
`1201`	`1203`	`if proxy_val:`