-
Notifications
You must be signed in to change notification settings - Fork 40
Updates timelock delay #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yahgwai
wants to merge
18
commits into
main
Choose a base branch
from
update-timelock-delay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
15e0994
Added core timelock update delay action
yahgwai 66a1e03
Set delay to const
yahgwai 83a4757
Set timelock to 8 days
yahgwai 3de99e6
Update src/gov-action-contracts/AIPs/CoreGovTimelockUpdateDelay.sol
yahgwai 6914bfa
Renamed to include action in file name
yahgwai 4fd7392
Added eight day to action name
yahgwai 9f11f57
Updated audit bypass
yahgwai bd0e85c
Dont use output logging branch
yahgwai 537006f
Added main branch for actions
yahgwai e28189b
Merge branch 'fix-branch' into update-timelock-delay
yahgwai 7b8747b
Added proposal generation
yahgwai 1fbc19f
Updated constitution hash
yahgwai 7266d24
Updated prop data
yahgwai 386bb1c
Updated prop data
yahgwai a23bfb1
update action address in generate script
godzillaba f616c31
Merge branch 'main' into update-timelock-delay
yahgwai 6c808ef
Updated roundtrip diagram
yahgwai 9072a47
Updated mermaid flow diagrams
yahgwai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
src/gov-action-contracts/AIPs/CoreGovTimelockUpdateDelay.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| pragma solidity 0.8.16; | ||
|
|
||
| import "../address-registries/L2AddressRegistryInterfaces.sol"; | ||
|
|
||
| /// @notice Updates the delay of the core gov timelock to 8 days | ||
| contract CoreGovTimelockUpdateDelayEightDayAction { | ||
| ICoreGovTimelockGetter public immutable govAddressRegistry; | ||
| uint256 public constant delay = 86400 * 8; | ||
|
|
||
| constructor(ICoreGovTimelockGetter _govAddressRegistry) { | ||
| govAddressRegistry = _govAddressRegistry; | ||
| } | ||
|
|
||
| function perform() external { | ||
| govAddressRegistry.coreGovTimelock().updateDelay(delay); | ||
| require( | ||
| govAddressRegistry.coreGovTimelock().getMinDelay() == delay, | ||
| "CoreGovTimelockUpdateDelayAction: Timelock delay" | ||
| ); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.